linux-kernel - Re: [PATCH 2/2] thermal: rcar_gen3_thermal: improve logging during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YqH1AofgJVvSpW/x@shikoro>
Date:   Thu, 9 Jun 2022 15:26:26 +0200
From:   Wolfram Sang <wsa+renesas@...g-engineering.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Niklas Söderlund <niklas.soderlund@...natech.se>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Linux PM list <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] thermal: rcar_gen3_thermal: improve logging during
 probe

Hi Geert,

> > -               dev_info(dev, "TSC%u: Loaded %d trip points\n", i, ret);
> > +               dev_info(dev, "Sensor %u: Trip points loaded: %u\n", i, ret);
> 
> I actually prefer the old wording (I'm undecided about "sensor" vs.
> "TSC", though, but consistency rules), as it makes it clear "ret"
> is the number of trip points, and not a success code.

I think "Sensor" is actually important. E.g. on Spider, Sensor 0 is TSC1
because there is no TSC0. So, the TSC numbering is confusing.

I'll try to reword it so that the number of points becomes clear again.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)