linux-kernel - Re: [PATCH] drm/sun4i: Add return statement in sun4i_layer_format_mod_supported Add a missing return after the IS_ERR_OR_NULL() check in sun4i_layer_format_mod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220609142253.7aad4jlaoahqkmy7@houat>
Date:   Thu, 9 Jun 2022 16:22:53 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Saud Farooqui <farooqui_saud@...mail.com>
Cc:     jernej.skrabec@...il.com, samuel@...lland.org,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        linux-kernel@...r.kernel.org, wens@...e.org, daniel@...ll.ch
Subject: Re: [PATCH] drm/sun4i: Add return statement in
 sun4i_layer_format_mod_supported Add a missing return after the
 IS_ERR_OR_NULL() check in sun4i_layer_format_mod_supported()

Hi,

On Tue, Jun 07, 2022 at 02:51:50PM +0500, Saud Farooqui wrote:
> Signed-off-by: Saud Farooqui <farooqui_saud@...mail.com>

Your patch doesn't seem to be formatted properly.

The commit title should be much shorter, and the commit log should
explain what the issue is, and what is done in that patch to address it.

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)