linux-kernel - Re: [PATCH v3] scripts/check-local-export: avoid 'wait $!' for process substitution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220610165724.16214-1-miles.chen@mediatek.com>
Date:   Sat, 11 Jun 2022 00:57:24 +0800
From:   Miles Chen <miles.chen@...iatek.com>
To:     <masahiroy@...nel.org>
CC:     <corbet@....net>, <jonathanh@...dia.com>,
        <linux-doc@...r.kernel.org>, <linux-kbuild@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <llvm@...ts.linux.dev>,
        <mpe@...erman.id.au>, <nathan@...nel.org>,
        <ndesaulniers@...gle.com>, <penguin-kernel@...ove.SAKURA.ne.jp>,
        <trix@...hat.com>, <wangyugui@...-tech.com>
Subject: Re: [PATCH v3] scripts/check-local-export: avoid 'wait $!' for process substitution

>Bash 4.4, released in 2016, supports 'wait $!' to check the exit status
>of a process substitution, but it seems too new.
>
>Some people using older bash versions (on CentOS 7, Ubuntu 16.04, etc.)
>reported an error like this:
>
>  ./scripts/check-local-export: line 54: wait: pid 17328 is not a child of this shell

Thanks for fixing this!
I hit this issue and this patch fixes my problem.

Tested-by: Miles Chen <miles.chen@...iatek.com> 

>
>I used the process substitution to avoid a pipeline, which executes each
>command in a subshell. If the while-loop is executed in the subshell
>context, variable changes within are lost after the subshell terminates.