linux-kernel - Re: [PATCH v1 1/1] hwmon: (nct6775) Drop duplicate NULL check in ->init() and ->exit()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YqOGXYiS6y19/8Yo@hatter.bewilderbeest.net>
Date:   Fri, 10 Jun 2022 10:58:53 -0700
From:   Zev Weiss <zev@...ilderbeest.net>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        Guenter Roeck <linux@...ck-us.net>,
        Jean Delvare <jdelvare@...e.com>
Subject: Re: [PATCH v1 1/1] hwmon: (nct6775) Drop duplicate NULL check in
 ->init() and ->exit()

On Fri, Jun 10, 2022 at 03:33:24AM PDT, Andy Shevchenko wrote:
>Since platform_device_unregister() is NULL-aware, we don't need to duplicate
>this check. Remove it and fold the rest of the code.
>
>Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>---
> drivers/hwmon/nct6775-platform.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>

Reviewed-by: Zev Weiss <zev@...ilderbeest.net>