[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YqOoI6g6GVw0Z1s/@ravnborg.org>
Date: Fri, 10 Jun 2022 22:22:59 +0200
From: Sam Ravnborg <sam@...nborg.org>
To: Stephen Kitt <steve@....org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Noralf Trønnes <noralf@...nnes.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Javier Martinez Canillas <javierm@...hat.com>,
Len Baker <len.baker@....com>, linux-fbdev@...r.kernel.org,
linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] staging: ftbft: Use backlight helper
Hi Stephen,
On Tue, Jun 07, 2022 at 08:55:16PM +0200, Stephen Kitt wrote:
> backlight_properties.fb_blank is deprecated. The states it represents
> are handled by other properties; but instead of accessing those
> properties directly, drivers should use the helpers provided by
> backlight.h.
>
> Instead of manually checking the power state in struct
> backlight_properties, use backlight_is_blank().
>
> Signed-off-by: Stephen Kitt <steve@....org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: "Noralf Trønnes" <noralf@...nnes.org>
> Cc: Thomas Zimmermann <tzimmermann@...e.de>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: Javier Martinez Canillas <javierm@...hat.com>
> Cc: Len Baker <len.baker@....com>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: linux-fbdev@...r.kernel.org
> Cc: linux-staging@...ts.linux.dev
> ---
> drivers/staging/fbtft/fb_ssd1351.c | 3 +--
> drivers/staging/fbtft/fbtft-core.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fb_ssd1351.c b/drivers/staging/fbtft/fb_ssd1351.c
> index 6fd549a424d5..b8d55aa8c5c7 100644
> --- a/drivers/staging/fbtft/fb_ssd1351.c
> +++ b/drivers/staging/fbtft/fb_ssd1351.c
> @@ -196,8 +196,7 @@ static int update_onboard_backlight(struct backlight_device *bd)
> "%s: power=%d, fb_blank=%d\n",
> __func__, bd->props.power, bd->props.fb_blank);
Could you try to kill this use of props.fb_blank too? ^^^^^^
A local variable should do the trick.
Sam
>
> - on = (bd->props.power == FB_BLANK_UNBLANK) &&
> - (bd->props.fb_blank == FB_BLANK_UNBLANK);
> + on = !backlight_is_blank(bd);
> /* Onboard backlight connected to GPIO0 on SSD1351, GPIO1 unused */
> write_reg(par, 0xB5, on ? 0x03 : 0x02);
>
> diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
> index 60b2278d8b16..9b3eaed80cdd 100644
> --- a/drivers/staging/fbtft/fbtft-core.c
> +++ b/drivers/staging/fbtft/fbtft-core.c
> @@ -137,8 +137,7 @@ static int fbtft_backlight_update_status(struct backlight_device *bd)
> "%s: polarity=%d, power=%d, fb_blank=%d\n",
> __func__, polarity, bd->props.power, bd->props.fb_blank);
>
> - if ((bd->props.power == FB_BLANK_UNBLANK) &&
> - (bd->props.fb_blank == FB_BLANK_UNBLANK))
> + if (!backlight_is_blank(bd))
> gpiod_set_value(par->gpio.led[0], polarity);
> else
> gpiod_set_value(par->gpio.led[0], !polarity);
>
> base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56
> --
> 2.30.2
Powered by blists - more mailing lists