linux-kernel - Re: [PATCH 1/7] fbdev: aty128fb: Use backlight helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YqOpmKlLl909F/Ib@ravnborg.org>
Date:   Fri, 10 Jun 2022 22:29:12 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Stephen Kitt <steve@....org>
Cc:     Antonino Daplas <adaplas@...il.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Helge Deller <deller@....de>,
        Paul Mackerras <paulus@...ba.org>, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 1/7] fbdev: aty128fb: Use backlight helper

Hi Stepehen,

On Tue, Jun 07, 2022 at 09:23:29PM +0200, Stephen Kitt wrote:
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
> 
> Signed-off-by: Stephen Kitt <steve@....org>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Helge Deller <deller@....de>
> Cc: linux-fbdev@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org

This and the other 6 patches in this series are all:
Reviewed-by: Sam Ravnborg <sam@...nborg.org>

I did not receive the cover letter, which is why I reply to this mail.

	Sam