linux-kernel - Re: [PATCH v2] gpio: dwapb: Don't print error on -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220610205459.ptgpuvtekwinujp2@mobilestation>
Date:   Fri, 10 Jun 2022 23:54:59 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Serge Semin <Sergey.Semin@...kalelectronics.ru>,
        Hoan Tran <hoan@...amperecomputing.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] gpio: dwapb: Don't print error on -EPROBE_DEFER

On Fri, Jun 10, 2022 at 02:13:51PM +0300, Andy Shevchenko wrote:
> On Fri, Jun 10, 2022 at 01:45:00PM +0300, Serge Semin wrote:
> > Currently if the APB or Debounce clocks aren't yet ready to be requested
> > the DW GPIO driver will correctly handle that by deferring the probe
> > procedure, but the error is still printed to the system log. It needlessly
> > pollutes the log since there was no real error but a request to postpone
> > the clock request procedure since the clocks subsystem hasn't been fully
> > initialized yet. Let's fix that by using the dev_err_probe method to print
> > the APB/clock request error status. It will correctly handle the deferred
> > probe situation and print the error if it actually happens.
> > 
> > Signed-off-by: Serge Semin <Sergey.Semin@...kalelectronics.ru>
> 

> With or without below nit-pick
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

Thanks.

> 
> > ---
> > 
> > Link: https://lore.kernel.org/linux-gpio/20220610075152.10214-1-Sergey.Semin@baikalelectronics.ru/
> > Changelog v2:
> > - Use the dev_err_probe() return value as the return status of the
> >   corresponding method. (@Philipp Zabel)
> > ---
> >  drivers/gpio/gpio-dwapb.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> > index b0f3aca61974..9467d695a33e 100644
> > --- a/drivers/gpio/gpio-dwapb.c
> > +++ b/drivers/gpio/gpio-dwapb.c
> > @@ -652,10 +652,9 @@ static int dwapb_get_clks(struct dwapb_gpio *gpio)
> >  	gpio->clks[1].id = "db";
> >  	err = devm_clk_bulk_get_optional(gpio->dev, DWAPB_NR_CLOCKS,
> >  					 gpio->clks);
> > -	if (err) {
> > -		dev_err(gpio->dev, "Cannot get APB/Debounce clocks\n");
> > -		return err;
> > -	}
> > +	if (err)
> > +		return dev_err_probe(gpio->dev, err,
> > +				     "Cannot get APB/Debounce clocks\n");
>
 
> I would leave it on one line, checkpatch wouldn't complain even before 100
> characters era.

You are right, checkpatch won't complain but the 80-chars limit is
still preferred. In this case we can fulfill that requirement without
harm to the code readability.

-Sergey

> 
> >  
> >  	err = clk_bulk_prepare_enable(DWAPB_NR_CLOCKS, gpio->clks);
> >  	if (err) {
> > -- 
> > 2.35.1
> > 
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>