linux-kernel - Re: [RFC PATCH v3 07/20] lkdtm: Emit an indirect call for CFI tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOd=GRwL6K7GxhiLhRhJVaD3a1VT6MD5fMR4kcYPpd5=0PQ@mail.gmail.com>
Date:   Fri, 10 Jun 2022 16:43:50 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Sami Tolvanen <samitolvanen@...gle.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Nathan Chancellor <nathan@...nel.org>,
        Joao Moreira <joao@...rdrivepizza.com>,
        Sedat Dilek <sedat.dilek@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-hardening@...r.kernel.org,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        clang-built-linux <llvm@...ts.linux.dev>
Subject: Re: [RFC PATCH v3 07/20] lkdtm: Emit an indirect call for CFI tests

On Fri, Jun 10, 2022 at 4:35 PM Sami Tolvanen <samitolvanen@...gle.com> wrote:
>
> Clang can convert the indirect calls in lkdtm_CFI_FORWARD_PROTO into
> direct calls. Move the call into a noinline function that accepts the
> target address as an argument to ensure the compiler actually emits an
> indirect call instead.

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>

>
> Signed-off-by: Sami Tolvanen <samitolvanen@...gle.com>
> ---
>  drivers/misc/lkdtm/cfi.c | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/misc/lkdtm/cfi.c b/drivers/misc/lkdtm/cfi.c
> index 666a7f4bc137..b6b375112a2a 100644
> --- a/drivers/misc/lkdtm/cfi.c
> +++ b/drivers/misc/lkdtm/cfi.c
> @@ -20,6 +20,13 @@ static noinline int lkdtm_increment_int(int *counter)
>
>         return *counter;
>  }
> +
> +/* Don't allow the compiler to inline the calls. */
> +static noinline void lkdtm_indirect_call(void (*func)(int *))
> +{
> +       func(&called_count);
> +}
> +
>  /*
>   * This tries to call an indirect function with a mismatched prototype.
>   */
> @@ -29,15 +36,11 @@ static void lkdtm_CFI_FORWARD_PROTO(void)
>          * Matches lkdtm_increment_void()'s prototype, but not
>          * lkdtm_increment_int()'s prototype.
>          */
> -       void (*func)(int *);
> -
>         pr_info("Calling matched prototype ...\n");
> -       func = lkdtm_increment_void;
> -       func(&called_count);
> +       lkdtm_indirect_call(lkdtm_increment_void);
>
>         pr_info("Calling mismatched prototype ...\n");
> -       func = (void *)lkdtm_increment_int;
> -       func(&called_count);
> +       lkdtm_indirect_call((void *)lkdtm_increment_int);
>
>         pr_err("FAIL: survived mismatched prototype function call!\n");
>         pr_expected_config(CONFIG_CFI_CLANG);
> --
> 2.36.1.476.g0c4daa206d-goog
>


-- 
Thanks,
~Nick Desaulniers