linux-kernel - RE: [PATCH v1 1/1] leds: core: Refactor led_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <372f05b312c54f808491d4fb3a2d7744@RCDC-Mail15.corp.diehl.com>
Date:   Fri, 10 Jun 2022 05:17:02 +0000
From:   Denis OSTERLAND-HEIM <denis.osterland@...hl.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Pavel Machek <pavel@....cz>
Subject: RE: [PATCH v1 1/1] leds: core: Refactor led_update_brightness() to
 use standard pattern

LGTM

Acked-by: Denis Osterland-Heim <denis.osterland@...hl.com>

-----Original Message-----
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Sent: Thursday, June 9, 2022 6:23 PM
To: Denis OSTERLAND-HEIM <denis.osterland@...hl.com>; Andy Shevchenko <andriy.shevchenko@...ux.intel.com>; linux-leds@...r.kernel.org; linux-kernel@...r.kernel.org
Cc: Pavel Machek <pavel@....cz>
Subject: [PATCH v1 1/1] leds: core: Refactor led_update_brightness() to use standard pattern

The standard conditional pattern is to check for errors first and bail out if any. Refactor led_update_brightness() accordingly.

While at it, drop unneeded assignment and return 0 unconditionally on success.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
---
 drivers/leds/led-core.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c index 4a97cb745788..96a2817712e5 100644
--- a/drivers/leds/led-core.c
+++ b/drivers/leds/led-core.c
@@ -304,17 +304,17 @@ EXPORT_SYMBOL_GPL(led_set_brightness_sync);

 int led_update_brightness(struct led_classdev *led_cdev)  {
-int ret = 0;
+int ret;

 if (led_cdev->brightness_get) {
 ret = led_cdev->brightness_get(led_cdev);
-if (ret >= 0) {
-led_cdev->brightness = ret;
-return 0;
-}
+if (ret < 0)
+return ret;
+
+led_cdev->brightness = ret;
 }

-return ret;
+return 0;
 }
 EXPORT_SYMBOL_GPL(led_update_brightness);

--
2.35.1
Diehl Metering GmbH, Donaustrasse 120, 90451 Nuernberg
Sitz der Gesellschaft: Ansbach, Registergericht: Ansbach HRB 69
Geschaeftsfuehrer: Dr. Christof Bosbach (Sprecher), Dipl.-Dolm. Annette Geuther, Dipl.-Kfm. Reiner Edel

Bitte denken Sie an die Umwelt, bevor Sie diese E-Mail drucken. Diese E-Mail kann vertrauliche Informationen enthalten. Sollten die in dieser E-Mail enthaltenen Informationen nicht für Sie bestimmt sein, informieren Sie bitte unverzueglich den Absender per E-Mail und loeschen Sie diese E-Mail in Ihrem System. Jede unberechtigte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt. Informationen zum Datenschutz finden Sie auf unserer Homepage<https://www.diehl.com/metering/de/impressum-und-rechtliche-hinweise/>.

Before printing, think about environmental responsibility.This message may contain confidential information. If you are not authorized to receive this information please advise the sender immediately by reply e-mail and delete this message without making any copies. Any form of unauthorized use, publication, reproduction, copying or disclosure of the e-mail is not permitted. Information about data protection can be found on our homepage<https://www.diehl.com/metering/en/data-protection/>.