linux-kernel - Re: [PATCH v5 3/4] fat: add renameat2 RENAME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7e264ff9-2ada-2413-110e-4105a5aadeae@redhat.com>
Date:   Fri, 10 Jun 2022 08:27:42 +0200
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:     linux-kernel@...r.kernel.org, Peter Jones <pjones@...hat.com>,
        Alexander Larsson <alexl@...hat.com>,
        Colin Walters <walters@...bum.org>,
        Alberto Ruiz <aruiz@...hat.com>,
        Muhammad Usama Anjum <usama.anjum@...labora.com>,
        Lennart Poettering <lennart@...ttering.net>,
        Chung-Chiang Cheng <cccheng@...ology.com>,
        Christian Kellner <ckellner@...hat.com>,
        Carlos Maiolino <cmaiolin@...hat.com>
Subject: Re: [PATCH v5 3/4] fat: add renameat2 RENAME_EXCHANGE flag support

On 6/10/22 05:17, OGAWA Hirofumi wrote:
> Javier Martinez Canillas <javierm@...hat.com> writes:
> 
>>>
>>> Looks like unnecessary complex (and comparing raw i_mode, not S_ISDIR(),
>>> better to change before make dir dirty).  How about this change, it is
>>> only tested slightly though? Can you review and test?
>>>
>>
>> Your change looks good to me and indeed the logic is simpler than in mine.
>>
>> I've also tested it and AFAICT it works correctly as well. Do you plan to
>> squash this or should I respin a new revision of the whole patch-set ? If
>> you want to post it as a follow-up I'm also OK with that.
> 
> Could you merge to your patchset, and re-send?
> 

Sure thing, I'll do that.

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat