linux-kernel - Re: [PATCH v2 45/48] ARM: dts: at91: correct gpio-keys properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44b011f6-6f4b-3816-1042-9a9b1fac3fa7@microchip.com>
Date:   Fri, 10 Jun 2022 07:12:47 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <krzysztof.kozlowski@...aro.org>, <arnd@...db.de>,
        <olof@...om.net>, <arm@...nel.org>, <soc@...nel.org>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 45/48] ARM: dts: at91: correct gpio-keys properties

On 09.06.2022 14:40, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> gpio-keys children do not use unit addresses.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Reviewed-by: Claudiu Beznea <claudiu.beznea@...rochip.com>


> ---
>  arch/arm/boot/dts/at91-kizbox.dts             | 2 --
>  arch/arm/boot/dts/at91-kizbox2-common.dtsi    | 2 --
>  arch/arm/boot/dts/at91-kizboxmini-common.dtsi | 2 --
>  arch/arm/boot/dts/at91-qil_a9260.dts          | 2 --
>  arch/arm/boot/dts/at91-wb45n.dts              | 5 +----
>  arch/arm/boot/dts/at91-wb50n.dts              | 8 ++------
>  6 files changed, 3 insertions(+), 18 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-kizbox.dts b/arch/arm/boot/dts/at91-kizbox.dts
> index 87e972eb2ba6..307663b4eec2 100644
> --- a/arch/arm/boot/dts/at91-kizbox.dts
> +++ b/arch/arm/boot/dts/at91-kizbox.dts
> @@ -30,8 +30,6 @@ main_xtal {
> 
>         gpio-keys {
>                 compatible = "gpio-keys";
> -               #address-cells = <1>;
> -               #size-cells = <0>;
> 
>                 button-reset {
>                         label = "PB_RST";
> diff --git a/arch/arm/boot/dts/at91-kizbox2-common.dtsi b/arch/arm/boot/dts/at91-kizbox2-common.dtsi
> index ed7146e23147..e5e21dff882f 100644
> --- a/arch/arm/boot/dts/at91-kizbox2-common.dtsi
> +++ b/arch/arm/boot/dts/at91-kizbox2-common.dtsi
> @@ -33,8 +33,6 @@ main_xtal {
> 
>         gpio-keys {
>                 compatible = "gpio-keys";
> -               #address-cells = <1>;
> -               #size-cells = <0>;
> 
>                 button-prog {
>                         label = "PB_PROG";
> diff --git a/arch/arm/boot/dts/at91-kizboxmini-common.dtsi b/arch/arm/boot/dts/at91-kizboxmini-common.dtsi
> index 8fb08e6fad7a..42640fe6b6d0 100644
> --- a/arch/arm/boot/dts/at91-kizboxmini-common.dtsi
> +++ b/arch/arm/boot/dts/at91-kizboxmini-common.dtsi
> @@ -36,8 +36,6 @@ adc_op_clk {
> 
>         gpio_keys {
>                 compatible = "gpio-keys";
> -               #address-cells = <1>;
> -               #size-cells = <0>;
> 
>                 key-prog {
>                         label = "PB_PROG";
> diff --git a/arch/arm/boot/dts/at91-qil_a9260.dts b/arch/arm/boot/dts/at91-qil_a9260.dts
> index d09b3d15a828..9d26f9996348 100644
> --- a/arch/arm/boot/dts/at91-qil_a9260.dts
> +++ b/arch/arm/boot/dts/at91-qil_a9260.dts
> @@ -198,8 +198,6 @@ user_led {
> 
>         gpio_keys {
>                 compatible = "gpio-keys";
> -               #address-cells = <1>;
> -               #size-cells = <0>;
> 
>                 button-user {
>                         label = "user_pb";
> diff --git a/arch/arm/boot/dts/at91-wb45n.dts b/arch/arm/boot/dts/at91-wb45n.dts
> index 3e46b29412d1..ef73f727f7bd 100644
> --- a/arch/arm/boot/dts/at91-wb45n.dts
> +++ b/arch/arm/boot/dts/at91-wb45n.dts
> @@ -14,11 +14,8 @@ / {
> 
>         gpio-keys {
>                 compatible = "gpio-keys";
> -               #address-cells = <1>;
> -               #size-cells = <0>;
> 
> -               irqbtn@18 {
> -                       reg = <18>;
> +               button {
>                         label = "IRQBTN";
>                         linux,code = <99>;
>                         gpios = <&pioB 18 GPIO_ACTIVE_LOW>;
> diff --git a/arch/arm/boot/dts/at91-wb50n.dts b/arch/arm/boot/dts/at91-wb50n.dts
> index e2195bd3e4b4..ec2becf6133b 100644
> --- a/arch/arm/boot/dts/at91-wb50n.dts
> +++ b/arch/arm/boot/dts/at91-wb50n.dts
> @@ -15,19 +15,15 @@ / {
> 
>         gpio-keys {
>                 compatible = "gpio-keys";
> -               #address-cells = <1>;
> -               #size-cells = <0>;
> 
> -               btn0@10 {
> -                       reg = <10>;
> +               button-0 {
>                         label = "BTNESC";
>                         linux,code = <1>; /* ESC button */
>                         gpios = <&pioA 10 GPIO_ACTIVE_LOW>;
>                         wakeup-source;
>                 };
> 
> -               irqbtn@31 {
> -                       reg = <31>;
> +               button-1 {
>                         label = "IRQBTN";
>                         linux,code = <99>; /* SysReq button */
>                         gpios = <&pioE 31 GPIO_ACTIVE_LOW>;
> --
> 2.34.1
>