linux-kernel - Re: [greybus-dev] Re: [PATCH v2] staging: greybus: audio: fix loop cursor use after iteration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YqL9+sx15/rqLlSZ@hovoldconsulting.com>
Date:   Fri, 10 Jun 2022 10:16:58 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Jared Kangas <kangas.jd@...il.com>, elder@...nel.org,
        greybus-dev@...ts.linaro.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [greybus-dev] Re: [PATCH v2] staging: greybus: audio: fix loop
 cursor use after iteration

On Fri, Jun 10, 2022 at 11:06:27AM +0300, Dan Carpenter wrote:
> On Fri, Jun 10, 2022 at 10:00:03AM +0200, Johan Hovold wrote:
> > > Fixes: 510e340efe0c ("staging: greybus: audio: Add helper APIs for dynamic audio modules")
> > > Cc: stable@...r.kernel.org
> > > Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>
> > > Reviewed-by: Johan Hovold <johan@...nel.org>
> > > Signed-off-by: Jared Kangas <kangas.jd@...il.com>
> > > ---
> > > 
> > > Changes since v1:
> > >  * Removed safe list iteration as suggested by Johan Hovold <johan@...nel.org>
> > >  * Updated patch changelog to explain the list iteration change
> > >  * Added tags to changelog based on feedback (Cc:, Fixes:, Reviewed-by:)
> > 
> > Apparently Greg applied this to staging-next before we had a change to
> > look at it. You should have received a notification from Greg when he
> > did so.
> > 
> > 	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-next&id=80c968a04a381dc0e690960c60ffd6b6aee7e157
> > 
> > It seems unlikely that this would cause any issues in real life, but
> > there's still a chance it will be picked up by the stable team despite
> > the lack of a CC stable tag.
> 
> If you want you can always email the stable team to pick up the patch.

Yes, of course. But it will be months before this fix hits mainline and
I probably won't remember to do so then.

I'm pretty sure Sasha's autosel tool will pick it up anyway, though.

Johan