linux-kernel - Re: [PATCH 1/2] blk-iocost: remove the second superfluous current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YqMExo7u9N4sVnyM@suselix>
Date:   Fri, 10 Jun 2022 10:45:58 +0200
From:   Andreas Herrmann <aherrmann@...e.de>
To:     Chengming Zhou <zhouchengming@...edance.com>
Cc:     tj@...nel.org, axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] blk-iocost: remove the second superfluous
 current_hweight

On Thu, Jun 09, 2022 at 03:34:49PM +0800, Chengming Zhou wrote:
> The commit ac33e91e2dac ("blk-iocost: implement vtime loss compensation")
> add the second current_hweight() in the loop of active iocgs list to
> get old_hwi to calculate the vtime loss of the iocg.
> 
> Since the hwi can't change and the first current_hweight already get
> hwa and hwi, so this second superfluous current_hweight() can be
> removed. There should be no functional changes.
> 
> Signed-off-by: Chengming Zhou <zhouchengming@...edance.com>

FWIW. Looks ok.
Reviewed-by: Andreas Herrmann <aherrmann@...e.de>