linux-kernel - Re: [PATCH] efi: sysfb_efi: remove unnecessary <asm/efi.h> include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXH5HfkqYYb+MKbEVNtpQnRULgZSCm7cWDP0SmrjthOFPQ@mail.gmail.com>
Date:   Fri, 10 Jun 2022 11:09:38 +0200
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Javier Martinez Canillas <javierm@...hat.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        linux-efi <linux-efi@...r.kernel.org>
Subject: Re: [PATCH] efi: sysfb_efi: remove unnecessary <asm/efi.h> include

On Fri, 10 Jun 2022 at 11:00, Javier Martinez Canillas
<javierm@...hat.com> wrote:
>
> Nothing defined in the header is used by drivers/firmware/efi/sysfb_efi.c
> but also, including it can lead to build errors when built on arches that
> don't have an asm/efi.h header file.
>
> This can happen for example if a driver that is built when COMPILE_TEST is
> enabled selects the SYSFB symbol, e.g. on powerpc with allyesconfig:
>
> drivers/firmware/efi/sysfb_efi.c:29:10: fatal error: asm/efi.h: No such file or directory
>    29 | #include <asm/efi.h>
>       |          ^~~~~~~~~~~
>
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>

Queued up in efi/urgent, thanks

> ---
>
>  drivers/firmware/efi/sysfb_efi.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/firmware/efi/sysfb_efi.c b/drivers/firmware/efi/sysfb_efi.c
> index 4c7c9dd7733f..7882d4b3f2be 100644
> --- a/drivers/firmware/efi/sysfb_efi.c
> +++ b/drivers/firmware/efi/sysfb_efi.c
> @@ -26,8 +26,6 @@
>  #include <linux/sysfb.h>
>  #include <video/vga.h>
>
> -#include <asm/efi.h>
> -
>  enum {
>         OVERRIDE_NONE = 0x0,
>         OVERRIDE_BASE = 0x1,
> --
> 2.36.1
>