linux-kernel - Re: [PATCH v9 1/2] thermal: Add thermal driver for Sunplus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e68724b0-4a9f-f564-c833-befd6c3515fb@linaro.org>
Date:   Fri, 10 Jun 2022 12:30:09 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Randy Dunlap <rdunlap@...radead.org>,
        郭力豪 <lhjeff911@...il.com>,
        rafael@...nel.org, Daniel Lezcano <daniel.lezcano@...aro.org>,
        amitk@...nel.org, rui.zhang@...el.com, robh+dt@...nel.org,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     "lh.kuo" <lh.kuo@...plus.com>,
        呂芳騰LuWells <wells.lu@...plus.com>
Subject: Re: [PATCH v9 1/2] thermal: Add thermal driver for Sunplus

On 10/06/2022 05:19, Randy Dunlap wrote:
> Hi--
> 
> On 6/9/22 18:32, 郭力豪 wrote:
>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
>> index 0e5cc94..c85e668 100644
>> --- a/drivers/thermal/Kconfig
>> +++ b/drivers/thermal/Kconfig
>> @@ -504,4 +504,14 @@ config KHADAS_MCU_FAN_THERMAL
>>     If you say yes here you get support for the FAN controlled
>>     by the Microcontroller found on the Khadas VIM boards.
>>
>> +config SUNPLUS_THERMAL
>> + tristate "Sunplus thermal drivers"
>> + depends on SOC_SP7021 || COMPILE_TEST
>> + help
>> +   This enable the Sunplus SP7021 thermal driver, which supports the primitive
>> +   temperature sensor embedded in Sunplus SP7021 SoC.
>> +
>> +   If you have a Sunplus SP7021 platform say Y here and enable this option
>> +   to have support for thermal management
> 
> End the sentence above with a period ('.').
> 
> And the indentation here is all messed up.
> See Documentation/process/coding-style.rst:
> 

It's not only this one. Entire file has wrong indentation.

Best regards,
Krzysztof