linux-kernel - Re: [PATCHv2 1/2] i2c: designware: introduce a custom scl recovery for SoCFPGA platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YqMsqwLgbI4AuzrE@smile.fi.intel.com>
Date:   Fri, 10 Jun 2022 14:36:11 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Dinh Nguyen <dinguyen@...nel.org>
Cc:     jarkko.nikula@...ux.intel.com, mika.westerberg@...ux.intel.com,
        robh+dt@...nel.org, krzk+dt@...nel.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCHv2 1/2] i2c: designware: introduce a custom scl recovery
 for SoCFPGA platforms

On Wed, Jun 01, 2022 at 08:48:07AM -0500, Dinh Nguyen wrote:
> On 5/24/22 11:43, Andy Shevchenko wrote:
> > On Tue, May 24, 2022 at 08:54:40AM -0500, Dinh Nguyen wrote:

...

> > > +	switch (dev->flags & MODEL_MASK) {
> > > +	case MODEL_SOCFPGA:
> > > +		rinfo->recover_bus = i2c_socfpga_scl_recovery;
> > > +		break;
> > > +	default:
> > > +		rinfo->recover_bus = i2c_generic_scl_recovery;
> > > +		break;
> > > +	}
> > 
> > > +	adap->bus_recovery_info = rinfo;
> > 
> > Usually we do not assign the pointer while data structure is incomplete.
> > That's said, please leave this line as it was.
> > 
> > On top of that, why you can't move the above switch to the place where old
> > function was assigned?
> 
> The reason is the assignment of the recover_bus needs to get done before the
> call to devm_gpiod_get_optional(), otherwise, the assignment is not taking
> place because of an error after returning from devm_gpiod_get_optional().

Update commit message accordingly then.

Also consider moving GPIO request part in the code, maybe it will bring better
looking / grouped code. Try and see, then choose the best one.

-- 
With Best Regards,
Andy Shevchenko