linux-kernel - Re: [PATCH v1 1/1] leds: trigger: gpio: Convert to use kstrtox()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YqMtXPVy2q0RRdky@smile.fi.intel.com>
Date:   Fri, 10 Jun 2022 14:39:08 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Pavel Machek <pavel@....cz>
Subject: Re: [PATCH v1 1/1] leds: trigger: gpio: Convert to use kstrtox()

On Thu, Jun 09, 2022 at 07:18:29PM +0300, Andy Shevchenko wrote:
> sscanf() is a heavy one and moreover requires additional boundary checks.
> Convert driver to use kstrtox() and replace kstrtoul() by kstrtobool()
> in gpio_trig_inverted_store().

> While here, check the desired brightness against maximum defined for
> a certain LED.

I realize that this part may be wrong. I have to drop it in the next version.

-- 
With Best Regards,
Andy Shevchenko