linux-kernel - [PATCH] driver:Change the return value to void and add the parameter name to lpfc_hba_down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 10 Jun 2022 08:07:49 -0400
From:   zhoun <zhounan@...china.com>
To:     martin.petersen@...cle.com, jejb@...ux.ibm.com,
        dick.kennedy@...adcom.com, james.smart@...adcom.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        zhoun <zhounan@...china.com>
Subject: [PATCH] driver:Change the return value to void and add the parameter name to lpfc_hba_down_prep

Optimize unused integer return values, add the parameter name to the 
function lpfc_hba_down_prep header file.

Signed-off-by: zhoun <zhounan@...china.com>

 Committer: zhoun <zhounan@...china.com>
---
 drivers/scsi/lpfc/lpfc_crtn.h | 2 +-
 drivers/scsi/lpfc/lpfc_init.c | 6 ++----
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_crtn.h b/drivers/scsi/lpfc/lpfc_crtn.h
index b1be0dd0337a..5f7bfbfd7cad 100644
--- a/drivers/scsi/lpfc/lpfc_crtn.h
+++ b/drivers/scsi/lpfc/lpfc_crtn.h
@@ -212,7 +212,7 @@ int lpfc_config_port_prep(struct lpfc_hba *);
 void lpfc_update_vport_wwn(struct lpfc_vport *vport);
 int lpfc_config_port_post(struct lpfc_hba *);
 int lpfc_sli4_refresh_params(struct lpfc_hba *phba);
-int lpfc_hba_down_prep(struct lpfc_hba *);
+void lpfc_hba_down_prep(struct lpfc_hba *phba);
 int lpfc_hba_down_post(struct lpfc_hba *);
 void lpfc_hba_init(struct lpfc_hba *, uint32_t *);
 int lpfc_sli3_post_buffer(struct lpfc_hba *phba, struct lpfc_sli_ring *pring, int cnt);
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 93b94c64518d..2439c474eddc 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -872,10 +872,9 @@ lpfc_hba_down_link(struct lpfc_hba *phba, uint32_t flag)
  * bringing down the SLI Layer.
  *
  * Return codes
- *   0 - success.
- *   Any other value - error.
+ *   void.
  **/
-int
+void
 lpfc_hba_down_prep(struct lpfc_hba *phba)
 {
 	struct lpfc_vport **vports;
@@ -897,7 +896,6 @@ lpfc_hba_down_prep(struct lpfc_hba *phba)
 				lpfc_cleanup_discovery_resources(vports[i]);
 		lpfc_destroy_vport_work_array(phba, vports);
 	}
-	return 0;
 }
 
 /**
-- 
2.27.0