[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VdPXHF96B5QWNOS3zfF+EOnWeRe+LCGnjvLBcb30kVzWg@mail.gmail.com>
Date: Fri, 10 Jun 2022 14:20:51 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Aswath Govindraju <a-govindraju@...com>
Cc: Vignesh Raghavendra <vigneshr@...com>,
Devarsh Thakkar <devarsht@...com>, Keerthy <j-keerthy@...com>,
Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>,
"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] gpio: davinci: Add support for system suspend/resume PM
On Fri, Jun 10, 2022 at 8:08 AM Aswath Govindraju <a-govindraju@...com> wrote:
>
> From: Devarsh Thakkar <devarsht@...com>
>
> Add support for system suspend/resume PM hooks, save the
> register context of all the required gpio registers on suspend
> and restore the context on resume.
the resume
...
> + writel_relaxed(0xFFFFFFFF, &g->intstat);
GENMASK(31, 0) ?
...
> +static int __maybe_unused davinci_gpio_suspend(struct device *dev)
> +static int __maybe_unused davinci_gpio_resume(struct device *dev)
> +static const struct dev_pm_ops davinci_gpio_dev_pm_ops = {
> + SET_SYSTEM_SLEEP_PM_OPS(davinci_gpio_suspend, davinci_gpio_resume)
> +};
> + .pm = &davinci_gpio_dev_pm_ops,
Can you utilize pm_sleep_ptr() and corresponding macros instead of
__maybe_unused?
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists