linux-kernel - Re: [PATCH 1/2] x86: notify hypervisor about guest entering s2idle state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2854ae00-e965-ab0f-80dd-6012ae36b271@intel.com>
Date:   Fri, 10 Jun 2022 05:49:04 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Grzegorz Jaszczyk <jaz@...ihalf.com>
Cc:     linux-kernel@...r.kernel.org, Dmytro Maluka <dmy@...ihalf.com>,
        Zide Chen <zide.chen@...el.corp-partner.google.com>,
        Peter Fang <peter.fang@...el.corp-partner.google.com>,
        Tomasz Nowicki <tn@...ihalf.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Jonathan Corbet <corbet@....net>,
        Sean Christopherson <seanjc@...gle.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>, Pavel Machek <pavel@....cz>,
        Brijesh Singh <brijesh.singh@....com>,
        Ashish Kalra <ashish.kalra@....com>,
        Mario Limonciello <mario.limonciello@....com>,
        Pratik Vishwakarma <Pratik.Vishwakarma@....com>,
        Hans de Goede <hdegoede@...hat.com>,
        Sachi King <nakato@...ato.io>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        David Dunn <daviddunn@...gle.com>,
        Wei Wang <wei.w.wang@...el.com>,
        Nicholas Piggin <npiggin@...il.com>,
        "open list:KERNEL VIRTUAL MACHINE (KVM)" <kvm@...r.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        "open list:ACPI" <linux-acpi@...r.kernel.org>,
        "open list:HIBERNATION (aka Software Suspend, aka swsusp)" 
        <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 1/2] x86: notify hypervisor about guest entering s2idle
 state

On 6/10/22 04:36, Grzegorz Jaszczyk wrote:
> czw., 9 cze 2022 o 16:27 Dave Hansen <dave.hansen@...el.com> napisał(a):
>> On 6/9/22 04:03, Grzegorz Jaszczyk wrote:
>>> Co-developed-by: Peter Fang <peter.fang@...el.corp-partner.google.com>
>>> Signed-off-by: Peter Fang <peter.fang@...el.corp-partner.google.com>
>>> Co-developed-by: Tomasz Nowicki <tn@...ihalf.com>
>>> Signed-off-by: Tomasz Nowicki <tn@...ihalf.com>
>>> Signed-off-by: Zide Chen <zide.chen@...el.corp-partner.google.com>
>>> Co-developed-by: Grzegorz Jaszczyk <jaz@...ihalf.com>
>>> Signed-off-by: Grzegorz Jaszczyk <jaz@...ihalf.com>
>>> ---
>>>  Documentation/virt/kvm/x86/hypercalls.rst | 7 +++++++
>>>  arch/x86/kvm/x86.c                        | 3 +++
>>>  drivers/acpi/x86/s2idle.c                 | 8 ++++++++
>>>  include/linux/suspend.h                   | 1 +
>>>  include/uapi/linux/kvm_para.h             | 1 +
>>>  kernel/power/suspend.c                    | 4 ++++
>>>  6 files changed, 24 insertions(+)
>> What's the deal with these emails?
>>
>>         zide.chen@...el.corp-partner.google.com
>>
>> I see a smattering of those in the git logs, but never for Intel folks.
> I've kept emails as they were in the original patch and I do not think
> I should change them. This is what Zide and Peter originally used.

"Original patch"?  Where did you get this from?

>> I'll also say that I'm a bit suspicious of a patch that includes 5
>> authors for 24 lines of code.  Did it really take five of you to write
>> 24 lines of code?
> This patch was built iteratively: original patch comes from Zide and
> Peter, I've squashed it with Tomasz later changes and reworked by
> myself for upstream. I didn't want to take credentials from any of the
> above so ended up with Zide as an author and 3 co-developers. Please
> let me know if that's an issue.

It just looks awfully fishy.

If it were me, and I'd put enough work into it to believe I deserved
credit as an *author* (again, of ~13 lines of actual code), I'd probably
just zap all the other SoB's and mention them in the changelog.  I'd
also explain where the code came from.

Your text above wouldn't be horrible context to add to a cover letter.