lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Jun 2022 15:04:31 +0000 From: "Neeli, Srinivas" <srinivas.neeli@....com> To: Alexandre Belloni <alexandre.belloni@...tlin.com>, Srinivas Neeli <srinivas.neeli@...inx.com> CC: "a.zummo@...ertech.it" <a.zummo@...ertech.it>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>, "michal.simek@...inx.com" <michal.simek@...inx.com>, "sgoud@...inx.com" <sgoud@...inx.com>, "shubhraj@...inx.com" <shubhraj@...inx.com>, "neelisrinivas18@...il.com" <neelisrinivas18@...il.com>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "git@...inx.com" <git@...inx.com> Subject: RE: [PATCH V7 3/3] rtc: zynqmp: Updated calibration value [AMD Official Use Only - General] Hi, > -----Original Message----- > From: Alexandre Belloni <alexandre.belloni@...tlin.com> > Sent: Friday, June 10, 2022 5:34 PM > To: Srinivas Neeli <srinivas.neeli@...inx.com> > Cc: a.zummo@...ertech.it; robh+dt@...nel.org; > krzysztof.kozlowski+dt@...aro.org; michal.simek@...inx.com; > sgoud@...inx.com; shubhraj@...inx.com; Neeli, Srinivas > <srinivas.neeli@....com>; neelisrinivas18@...il.com; > devicetree@...r.kernel.org; linux-rtc@...r.kernel.org; linux-arm- > kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; git@...inx.com > Subject: Re: [PATCH V7 3/3] rtc: zynqmp: Updated calibration value > > On 10/06/2022 17:07:09+0530, Srinivas Neeli wrote: > > As per RTC spec default calibration value is 0x7FFF. > > > > Having that as a second patch breaks the calculation in your previous patch, > really, this should just be a single patch. Can I swap 3/3 and 2/3, Will that be fine ?. > > > Signed-off-by: Srinivas Neeli <srinivas.neeli@...inx.com> > > --- > > Changes in V7: > > -New patch > > -TRM not updated yet, Internal design document contains 0x7FFF as > > default value. TRM Will update in next release. > > --- > > drivers/rtc/rtc-zynqmp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/rtc/rtc-zynqmp.c b/drivers/rtc/rtc-zynqmp.c index > > 39b23f88ee26..1dd389b891fe 100644 > > --- a/drivers/rtc/rtc-zynqmp.c > > +++ b/drivers/rtc/rtc-zynqmp.c > > @@ -37,7 +37,7 @@ > > #define RTC_OSC_EN BIT(24) > > #define RTC_BATT_EN BIT(31) > > > > -#define RTC_CALIB_DEF 0x198233 > > +#define RTC_CALIB_DEF 0x7FFF > > #define RTC_CALIB_MASK 0x1FFFFF > > #define RTC_ALRM_MASK BIT(1) > > #define RTC_MSEC 1000 > > -- > > 2.25.1 > > > > -- > Alexandre Belloni, co-owner and COO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
Powered by blists - more mailing lists