linux-kernel - Re: [PATCH] kbuild: use a pipe rather than process substitution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQaN0pH01Ntsn9jRxciaiYtWUA8MJeJ9ELiXrrbQwms6g@mail.gmail.com>
Date:   Sat, 11 Jun 2022 17:40:08 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Alvin Šipraga <ALSI@...g-olufsen.dk>
Cc:     Alvin Šipraga <alvin@...s.dk>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>,
        "linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>
Subject: Re: [PATCH] kbuild: use a pipe rather than process substitution

On Sat, Jun 11, 2022 at 6:40 AM Alvin Šipraga <ALSI@...g-olufsen.dk> wrote:
>
> On Fri, Jun 10, 2022 at 11:34:52PM +0200, Alvin Šipraga wrote:
> > From: Alvin Šipraga <alsi@...g-olufsen.dk>
> >
> > Bash process substitution of the form `foo < <(bar)`, as found in
> > scripts/check-local-export, can cause issues in chrooted environments
> > and with tools such as pseudo. The blamed commit started to cause build
> > errors for me when using the Yocto project's devshell environment;
> > devshell uses pseudo internally:
> >
> > .../scripts/check-local-export: line 51: /dev/fd/63: No such file or directory
> >
> > Replace the process substitution with a simple pipe into the while loop.
> > This is functionally equivalent and more portable than the former. Note
> > that pipefail is enabled so that the script terminates when ${NM} fails.
> >
> > Link: https://bugzilla.yoctoproject.org/show_bug.cgi?id=13288
> > Fixes: 31cb50b5590f ("kbuild: check static EXPORT_SYMBOL* by script instead of modpost")
> > Signed-off-by: Alvin Šipraga <alsi@...g-olufsen.dk>
>
> Oops, I forgot to check the linux-kbuild list before sending this patch. I see
> that a more robust patch has been posted which addresses a separate issue, but
> which also solves the issue I was trying to address:
>
> https://lore.kernel.org/linux-kbuild/20220608011100.486735-1-masahiroy@kernel.org/raw
>
> Please ignore this. Thanks!
>
> Kind regards,
> Alvin

No problem. I did not notice I had broken yocto builds,
and it is good to know it has been solved as well.
Thanks for the report.



-- 
Best Regards
Masahiro Yamada