linux-kernel - Re: [PATCH] scripts/gdb: change kernel config dumping method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNATknxrmnAXKkz-XzkGn1kprPiQLrjKSdp4wKCRhPczcmA@mail.gmail.com>
Date:   Sat, 11 Jun 2022 18:37:41 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Kuan-Ying Lee <Kuan-Ying.Lee@...iatek.com>
Cc:     Jan Kiszka <jan.kiszka@...mens.com>,
        Kieran Bingham <kbingham@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        chinwen.chang@...iatek.com, nicholas.tang@...iatek.com,
        casper.li@...iatek.com, andrew.yang@...iatek.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH] scripts/gdb: change kernel config dumping method

On Fri, Jun 10, 2022 at 4:15 PM Kuan-Ying Lee
<Kuan-Ying.Lee@...iatek.com> wrote:
>
> MAGIC_START("IKCFG_ST") and MAGIC_END("IKCFG_ED") are moved out
> from the kernel_config_data variable [1].
>
> Thus, we parse kernel_config_data directly instead of considering
> offset of MAGIC_START and MAGIC_END.
>
> [1] https://lore.kernel.org/lkml/1550108893-21226-1-git-send-email-yamada.masahiro@socionext.com/
>
> Fixes: 13610aa908dc ("kernel/configs: use .incbin directive to embed config_data.gz")
> Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@...iatek.com>


Thanks for the fix.

Applied to linux-kbuild/fixes.




> ---
>  scripts/gdb/linux/config.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/gdb/linux/config.py b/scripts/gdb/linux/config.py
> index 90e1565b1967..8843ab3cbadd 100644
> --- a/scripts/gdb/linux/config.py
> +++ b/scripts/gdb/linux/config.py
> @@ -24,9 +24,9 @@ class LxConfigDump(gdb.Command):
>              filename = arg
>
>          try:
> -            py_config_ptr = gdb.parse_and_eval("kernel_config_data + 8")
> -            py_config_size = gdb.parse_and_eval(
> -                    "sizeof(kernel_config_data) - 1 - 8 * 2")
> +            py_config_ptr = gdb.parse_and_eval("&kernel_config_data")
> +            py_config_ptr_end = gdb.parse_and_eval("&kernel_config_data_end")
> +            py_config_size = py_config_ptr_end - py_config_ptr
>          except gdb.error as e:
>              raise gdb.GdbError("Can't find config, enable CONFIG_IKCONFIG?")
>
> --
> 2.18.0
>


-- 
Best Regards
Masahiro Yamada