linux-kernel - Re: [PATCH] powerpc/rng: wire up during setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <230d6927-b11a-fbf2-fb1c-fa9df70acfa0@csgroup.eu>
Date:   Sat, 11 Jun 2022 10:41:52 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
CC:     "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] powerpc/rng: wire up during setup_arch



Le 11/06/2022 à 11:58, Jason A. Donenfeld a écrit :
> Hi Christophe,
> 
> On Sat, Jun 11, 2022 at 09:27:43AM +0000, Christophe Leroy wrote:
>> Le 11/06/2022 à 11:22, Jason A. Donenfeld a écrit :
>>> Hi Christophe,
>>>
>>> On Sat, Jun 11, 2022 at 11:17:23AM +0200, Christophe Leroy wrote:
>>>> Also, you copied stable. Should you add a Fixes: tag so that we know
>>>> what it fixes ?
>>>
>>> I suppose the fixes tag would be whatever introduced those files in the
>>> first place, so not all together useful. But if you want something, feel
>>> free to append these when applying the commit:
>>>
>>> Fixes: a4da0d50b2a0 ("powerpc: Implement arch_get_random_long/int() for powernv")
>>> Fixes: a489043f4626 ("powerpc/pseries: Implement arch_get_random_long() based on H_RANDOM")
>>> Fixes: c25769fddaec ("powerpc/microwatt: Add support for hardware random number generator")
>>>
>>
>> Well it helps knowing on which stable version it applies.
>>
>> Maybe it would be cleaner to send three patches ? After all they look
> 
> Sounds like irritating paperwork to me.

It helps with application to stable.

Two of the above commits are in v3.12, the other one appears in v5.13

So having the microwatt in a separate patch should ease.

> 
>> like 3 independant changes with nothing in common at all.
> 
> "Nothing in common"? I don't know about that.

I mean no common file that needs to be changed for the three platforms, 
so it makes it easy.


> 
> Anyway, sure, I'll do that and send a v2 series.
> 

As they are independant it doesn't need to be a series at all. But 
that's fine if it is a series as well.

Christophe