lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 11 Jun 2022 16:41:58 +0200 From: "Jason A. Donenfeld" <Jason@...c4.com> To: Christophe Leroy <christophe.leroy@...roup.eu> Cc: "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Michael Ellerman <mpe@...erman.id.au>, "stable@...r.kernel.org" <stable@...r.kernel.org> Subject: Re: [PATCH v2 1/3] powerpc/microwatt: wire up rng during setup_arch Hi Christophe, On Sat, Jun 11, 2022 at 4:40 PM Christophe Leroy <christophe.leroy@...roup.eu> wrote: > > > > +__init void microwatt_rng_init(void); > > This prototype should be declared in a header file, for instance asm/setup.h Alright. > And I think the __init keyword usually goes after the type, so should be > 'void __init'. Indeed I thought so too. It just wasn't like this before, but that doesn't mean I shouldn't fix it. v3 coming right up. Jason
Powered by blists - more mailing lists