linux-kernel - Re: [PATCH] mm, slab: fix bad alignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YqQQ8HallkC5pTBV@hyeyoo>
Date:   Sat, 11 Jun 2022 12:50:08 +0900
From:   Hyeonggon Yoo <42.hyeyoo@...il.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     cl@...ux.com, penberg@...nel.org, rientjes@...gle.com,
        iamjoonsoo.kim@....com, akpm@...ux-foundation.org, vbabka@...e.cz,
        roman.gushchin@...ux.dev, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] mm, slab: fix bad alignments

On Thu, Jun 09, 2022 at 12:01:32PM +0800, Jiapeng Chong wrote:
> As reported by coccicheck:
> 
> ./mm/slab.c:3253:2-59: code aligned with following code on line 3255.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  mm/slab.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/slab.c b/mm/slab.c
> index 47151fb2b2d2..c359c0f2c897 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -3223,7 +3223,7 @@ slab_alloc_node(struct kmem_cache *cachep, gfp_t flags, int nodeid, size_t orig_
>  	}
>  	/* ___cache_alloc_node can fall back to other nodes */
>  	ptr = ____cache_alloc_node(cachep, flags, nodeid);
> -  out:
> +out:
>  	local_irq_restore(save_flags);
>  	ptr = cache_alloc_debugcheck_after(cachep, flags, ptr, caller);
>  	init = slab_want_init_on_alloc(flags, cachep);
> @@ -3252,7 +3252,7 @@ __do_cache_alloc(struct kmem_cache *cache, gfp_t flags)
>  	if (!objp)
>  		objp = ____cache_alloc_node(cache, flags, numa_mem_id());
>  
> -  out:
> +out:
>  	return objp;
>  }
>  #else
> -- 
> 2.20.1.7.g153144c

Acked-by: Hyeonggon Yoo <42.hyeyoo@...il.com>

-- 
Thanks,
Hyeonggon