linux-kernel - Re: [PATCH] mm: kmem: make mem_cgroup_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <355332ef-838b-3847-5a95-de5017b0301d@openvz.org>
Date:   Sat, 11 Jun 2022 07:10:06 +0300
From:   Vasily Averin <vvs@...nvz.org>
To:     Roman Gushchin <roman.gushchin@...ux.dev>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        Qian Cai <quic_qiancai@...cinc.com>,
        Kefeng Wang <wangkefeng.wang@...wei.com>,
        Linux Kernel Functional Testing <lkft@...aro.org>,
        Shakeel Butt <shakeelb@...gle.com>
Subject: Re: [PATCH] mm: kmem: make mem_cgroup_from_obj() vmalloc()-safe

On 6/10/22 21:10, Roman Gushchin wrote:
> On Fri, Jun 10, 2022 at 11:03:10AM -0700, Roman Gushchin wrote:
>> Currently mem_cgroup_from_obj() is not working properly with objects
>> allocated using vmalloc(). It creates problems in some cases, when
>> it's called for static objects belonging to  modules or generally
>> allocated using vmalloc().
>>
>> This patch makes mem_cgroup_from_obj() safe to be called on objects
>> allocated using vmalloc().
>>
>> It also introduces mem_cgroup_from_slab_obj(), which is a faster
>> version to use in places when we know the object is either a slab
>> object or a generic slab page (e.g. when adding an object to a lru
>> list).
>>
>> Suggested-by: Kefeng Wang <wangkefeng.wang@...wei.com>
>> Signed-off-by: Roman Gushchin <roman.gushchin@...ux.dev>
>> Tested-by: Linux Kernel Functional Testing <lkft@...aro.org>
>> Acked-by: Shakeel Butt <shakeelb@...gle.com>
> 
> Andrew,
> 
> this patch is supposed to fix boot issues on arm introduced by
> the commit "net: set proper memcg for net_init hooks allocations".
> 
> But as no I don't see this commit in linux-next or any mm branches,
> so I'm not sure if it's in stable or not. So I didn't add the Fixes
> tag. If it isn't in stable yet, I'd just put the fix before the problematic
> commit.

Roman,
Andrew dropped "net: set proper memcg for net_init hooks allocations" few days ago,
but I hope he will re-apply it again after your patch.
Thank you very much for your help!

	Vasily Averin