linux-kernel - RE: [PATCH] rcu-tasks: Remove unused trc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR11MB5880271642F637C44F06BA8DDAA99@PH0PR11MB5880.namprd11.prod.outlook.com>
Date:   Sat, 11 Jun 2022 05:12:54 +0000
From:   "Zhang, Qiang1" <qiang1.zhang@...el.com>
To:     "paulmck@...nel.org" <paulmck@...nel.org>
CC:     "frederic@...nel.org" <frederic@...nel.org>,
        "rcu@...r.kernel.org" <rcu@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] rcu-tasks: Remove unused trc_wait and holdouts

On Fri, Jun 10, 2022 at 02:22:28PM +0800, Zqiang wrote:
> Remove unused trc_wait waitqueue and local holdouts list.
> 
> Signed-off-by: Zqiang <qiang1.zhang@...el.com>
>
>Good eyes, thank you!  I will fold this into the original commit with attribution.

Thanks
Zqiang

>
>							Thanx, Paul

> ---
>  kernel/rcu/tasks.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h index 
> 55e76db8b0d3..fcbd0ec33c86 100644
> --- a/kernel/rcu/tasks.h
> +++ b/kernel/rcu/tasks.h
> @@ -1190,8 +1190,6 @@ EXPORT_SYMBOL_GPL(rcu_trace_lock_map);
>  
>  #ifdef CONFIG_TASKS_TRACE_RCU
>  
> -static DECLARE_WAIT_QUEUE_HEAD(trc_wait);	// List of holdout tasks.
> -
>  // Record outstanding IPIs to each CPU.  No point in sending two...
>  static DEFINE_PER_CPU(bool, trc_ipi_to_cpu);
>  
> @@ -1641,7 +1639,6 @@ static void rcu_tasks_trace_empty_fn(void 
> *unused)  static void rcu_tasks_trace_postgp(struct rcu_tasks *rtp)  {
>  	int cpu;
> -	LIST_HEAD(holdouts);
>  
>  	// Wait for any lingering IPI handlers to complete.  Note that
>  	// if a CPU has gone offline or transitioned to userspace in the
> --
> 2.25.1
>