linux-kernel - Re: [PATCH] ata: handle failure of devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f22ad6a-81a2-d7e9-6fe8-baf5b42f12a9@nfschina.com>
Date:   Sun, 12 Jun 2022 20:34:29 +0800
From:   liqiong <liqiong@...china.com>
To:     Sergey Shtylyov <s.shtylyov@....ru>,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
        hukun@...china.com, qixu@...china.com, yuzhe@...china.com,
        renyu@...china.com
Subject: Re: [PATCH] ata: handle failure of devm_ioremap()



在 2022年06月12日 17:06, Sergey Shtylyov 写道:
> Hello!
>
>    The subject should include the driver's name, like below:
>
> ata: pata_pxa: handle failure of devm_ioremap()
>
> On 6/12/22 10:32 AM, Li Qiong wrote:
>
>> As the possible failure of the devm_ioremap(), the return value
>> could be NULL. Therefore it should be better to check it and
>> print error message, return '-ENOMEM' error code.
>>
>> Signed-off-by: Li Qiong <liqiong@...china.com>
>
> Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>
>
> [...]
>
> MBR, Sergey

Thanks, I will submit a v2 patch.