linux-kernel - Re: [PATCH AUTOSEL 5.10 21/38] accessiblity: speakup: Add missing misc_deregister in softsynth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YqYmt5wAXWt7Ggzu@sashalap>
Date:   Sun, 12 Jun 2022 13:47:35 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Pavel Machek <pavel@...x.de>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Zheng Bin <zhengbin13@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        w.d.hubbs@...il.com, chris@...-brannons.com, kirk@...sers.ca,
        samuel.thibault@...-lyon.org, trix@...hat.com,
        salah.triki@...il.com, speakup@...ux-speakup.org
Subject: Re: [PATCH AUTOSEL 5.10 21/38] accessiblity: speakup: Add missing
 misc_deregister in softsynth_probe

On Wed, Jun 08, 2022 at 11:08:30PM +0200, Pavel Machek wrote:
>Hi!
>
>> From: Zheng Bin <zhengbin13@...wei.com>
>>
>> [ Upstream commit 106101303eda8f93c65158e5d72b2cc6088ed034 ]
>>
>> softsynth_probe misses a call misc_deregister() in an error path, this
>> patch fixes that.
>
>This seems incorrect. Registration failed, we can't really deregister.
>
>I checked random other caller of misc_register(), and it does not seem
>this API is unusual.

Uh, yes, I'll drop it for now.

-- 
Thanks,
Sasha