linux-kernel - Re: [PATCH 1/2] module: Fix ERRORs reported by checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61a0e770b1738579a076bd4642c27a7ca8e6c297.camel@perches.com>
Date:   Sun, 12 Jun 2022 12:35:55 -0700
From:   Joe Perches <joe@...ches.com>
To:     Christophe Leroy <christophe.leroy@...roup.eu>,
        Luis Chamberlain <mcgrof@...nel.org>,
        linux-modules@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] module: Fix ERRORs reported by checkpatch.pl

On Sun, 2022-06-12 at 19:44 +0200, Christophe Leroy wrote:
> Checkpatch reports following errors:

There are many conditions that checkpatch reports that do
not need fixing.

checkpatch is a mindless script.  It's not always right.

> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
[]
> diff --git a/kernel/module/main.c b/kernel/module/main.c
[]
> @@ -1111,9 +1111,9 @@ resolve_symbol_wait(struct module *mod,
>  	const struct kernel_symbol *ksym;
>  	char owner[MODULE_NAME_LEN];
>  
> +	ksym = resolve_symbol(mod, info, name, owner);
>  	if (wait_event_interruptible_timeout(module_wq,

Did you verify this change by looking at the code for
wait_event_interruptible_timeout?

> -			!IS_ERR(ksym = resolve_symbol(mod, info, name, owner))
> -			|| PTR_ERR(ksym) != -EBUSY,
> +			!IS_ERR(ksym) || PTR_ERR(ksym) != -EBUSY,
>  					     30 * HZ) <= 0) {
>  		pr_warn("%s: gave up waiting for init of module %s.\n",
>  			mod->name, owner);