lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 12 Jun 2022 15:32:22 +0800 From: Li Qiong <liqiong@...china.com> To: Sergey Shtylyov <s.shtylyov@....ru>, Damien Le Moal <damien.lemoal@...nsource.wdc.com> Cc: linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org, hukun@...china.com, qixu@...china.com, yuzhe@...china.com, renyu@...china.com, Li Qiong <liqiong@...china.com> Subject: [PATCH] ata: handle failure of devm_ioremap() As the possible failure of the devm_ioremap(), the return value could be NULL. Therefore it should be better to check it and print error message, return '-ENOMEM' error code. Signed-off-by: Li Qiong <liqiong@...china.com> --- drivers/ata/pata_pxa.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c index 985f42c4fd70..cd1a8f37f920 100644 --- a/drivers/ata/pata_pxa.c +++ b/drivers/ata/pata_pxa.c @@ -228,6 +228,11 @@ static int pxa_ata_probe(struct platform_device *pdev) ap->ioaddr.bmdma_addr = devm_ioremap(&pdev->dev, dma_res->start, resource_size(dma_res)); + if (!ap->ioaddr.cmd_addr || !ap->ioaddr.ctl_addr || !ap->ioaddr.bmdma_addr) { + dev_err(&pdev->dev, "failed to map ap->ioaddr\n"); + return -ENOMEM; + } + /* * Adjust register offsets */ -- 2.11.0
Powered by blists - more mailing lists