linux-kernel - Re: [btrfs] 62bd8124e2: WARNING:at_fs/btrfs/block-rsv.c:#btrfs_release_global_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Jun 2022 11:50:05 +0100
From:   Filipe Manana <fdmanana@...nel.org>
To:     Oliver Sang <oliver.sang@...el.com>
Cc:     0day robot <lkp@...el.com>, LKML <linux-kernel@...r.kernel.org>,
        linux-btrfs <linux-btrfs@...r.kernel.org>, lkp@...ts.01.org
Subject: Re: [btrfs] 62bd8124e2: WARNING:at_fs/btrfs/block-rsv.c:#btrfs_release_global_block_rsv[btrfs]

On Sun, Jun 12, 2022 at 3:37 PM Oliver Sang <oliver.sang@...el.com> wrote:
>
> hi, Filipe Manana,
>
> On Fri, Jun 10, 2022 at 09:26:59AM +0800, Oliver Sang wrote:
> > hi, Filipe Manana,
> >
> > On Thu, Jun 09, 2022 at 10:46:52AM +0100, Filipe Manana wrote:
> > >
> > > I am unable to reproduce that on a 12 cores box.
> > > I also don't see anything wrong that could lead to that by manual inspection.
> > >
> > > How easy is it for you to trigger it?
> >
> > we reproduced this upon 62bd8124e2 4 times out of 6 runs.
> > but since the other 2 runs crash early due to other issues (below (1)), we
> > cannot say they are clean.
> > at the same time, the 6 runs for parent are clean.
> >
> > 7e2bb5b3f3bca223 62bd8124e2f17910fcd89568e50
> > ---------------- ---------------------------
> >        fail:runs  %reproduction    fail:runs
> >            |             |             |
> >            :6           67%           4:6     dmesg.RIP:btrfs_release_global_block_rsv[btrfs]
> >            :6           67%           4:6     dmesg.WARNING:at_fs/btrfs/block-rsv.c:#btrfs_release_global_block_rsv[btrfs]
> >            :6           33%           2:6     dmesg.kernel_BUG_at_fs/xfs/xfs_message.c  <----- (1)
> >
> >
> > >
> > > Can you also run it with CONFIG_BTRFS_ASSERT=y set in the kernel config?
> >
> > got it, we will enable this config and rerun tests, for both this commit and
> > parent.
>
> we enabled CONFIG_BTRFS_ASSERT=y as attached config and rerun tests, still can
> reproduce the issue, like:
>
>
> 7e2bb5b3f3bca223 62bd8124e2f17910fcd89568e50
> ---------------- ---------------------------
>        fail:runs  %reproduction    fail:runs
>            |             |             |
>            :16          94%          15:16    dmesg.RIP:btrfs_release_global_block_rsv[btrfs]
>            :16          94%          15:16    dmesg.WARNING:at_fs/btrfs/block-rsv.c:#btrfs_release_global_block_rsv[btrfs]
>            :16           6%           1:16    dmesg.kernel_BUG_at_fs/xfs/xfs_message.c
>
>
> attached one dmesg FYI

Thanks for running the test again Oliver.
Running the fxmark test on my machines, I can't trigger anything.

May I ask you to run again the test but with the attached debug patch
on top of it?

Also, if possible, with ftrace enabled like this:

modprobe btrfs
echo 0 > /sys/kernel/debug/tracing/tracing_on
echo > /sys/kernel/debug/tracing/trace
echo $((1 << 24)) > /sys/kernel/debug/tracing/buffer_size_kb
echo nop > /sys/kernel/debug/tracing/current_tracer
echo 1 > /sys/kernel/tracing/events/btrfs/btrfs_space_reservation/enable

echo 1 > /sys/kernel/debug/tracing/tracing_on

<run the test>

echo 0 > /sys/kernel/debug/tracing/tracing_on

Then collect the trace to a file and send it over to me:

cat /sys/kernel/debug/tracing/trace | xz -9 > trace.txt.xz

And of course, the dmesg result as well.

Thanks!



>
> >

View attachment "btrfs_debug.patch" of type "text/x-patch" (6725 bytes)