linux-kernel - arch/x86/kvm/svm/sev.c:1605:30: warning: parameter 'role' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <202206131853.x4KJwC5Q-lkp@intel.com>
Date:   Mon, 13 Jun 2022 19:03:00 +0800
From:   kernel test robot <lkp@...el.com>
To:     Peter Gonda <pgonda@...gle.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, Paolo Bonzini <pbonzini@...hat.com>
Subject: arch/x86/kvm/svm/sev.c:1605:30: warning: parameter 'role' set but
 not used

Hi Peter,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3
commit: 0c2c7c069285374fc8feacddc0498f8ab7627117 KVM: SEV: Mark nested locking of vcpu->lock
date:   5 weeks ago
config: x86_64-buildonly-randconfig-r005-20220613 (https://download.01.org/0day-ci/archive/20220613/202206131853.x4KJwC5Q-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d378268ead93c85803c270277f0243737b536ae7)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c2c7c069285374fc8feacddc0498f8ab7627117
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 0c2c7c069285374fc8feacddc0498f8ab7627117
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/kvm/ drivers/media/platform/qcom/camss/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> arch/x86/kvm/svm/sev.c:1605:30: warning: parameter 'role' set but not used [-Wunused-but-set-parameter]
                                           enum sev_migration_role role)
                                                                   ^
   1 warning generated.


vim +/role +1605 arch/x86/kvm/svm/sev.c

  1603	
  1604	static int sev_lock_vcpus_for_migration(struct kvm *kvm,
> 1605						enum sev_migration_role role)
  1606	{
  1607		struct kvm_vcpu *vcpu;
  1608		unsigned long i, j;
  1609		bool first = true;
  1610	
  1611		kvm_for_each_vcpu(i, vcpu, kvm) {
  1612			if (mutex_lock_killable_nested(&vcpu->mutex, role))
  1613				goto out_unlock;
  1614	
  1615			if (first) {
  1616				/*
  1617				 * Reset the role to one that avoids colliding with
  1618				 * the role used for the first vcpu mutex.
  1619				 */
  1620				role = SEV_NR_MIGRATION_ROLES;
  1621				first = false;
  1622			} else {
  1623				mutex_release(&vcpu->mutex.dep_map, _THIS_IP_);
  1624			}
  1625		}
  1626	
  1627		return 0;
  1628	
  1629	out_unlock:
  1630	
  1631		first = true;
  1632		kvm_for_each_vcpu(j, vcpu, kvm) {
  1633			if (i == j)
  1634				break;
  1635	
  1636			if (first)
  1637				first = false;
  1638			else
  1639				mutex_acquire(&vcpu->mutex.dep_map, role, 0, _THIS_IP_);
  1640	
  1641	
  1642			mutex_unlock(&vcpu->mutex);
  1643		}
  1644		return -EINTR;
  1645	}
  1646	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp