linux-kernel - Re: [PATCH] spi: spidev_test: Warn when the mode is not the requested mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yqco2kRAKBJ+fQkf@sirena.org.uk>
Date:   Mon, 13 Jun 2022 13:08:58 +0100
From:   Mark Brown <broonie@...nel.org>
To:     David Fries <David@...es.net>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: spidev_test: Warn when the mode is not the
 requested mode

On Mon, Jun 13, 2022 at 12:39:41AM -0500, David Fries wrote:

> +	/* Drivers can reject some mode bits without returning an error.
> +	 * Read the current value to identify what mode it is in, and if it
> +	 * differs from the requested mode, warn the user.
> +	 */
> +	if(request != mode)

Please try to follow the kernel coding style - both the if( and the
comment don't.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)