linux-kernel - Re: [PATCH] ARM: dts: bcm2711-rpi-4-b: Use aliases to set custom MMC device index

Open Source and information security mailing list archives

Date:   Mon, 13 Jun 2022 09:46:58 -0300
From:   Ariel D'Alessandro <ariel.dalessandro@...labora.com>
To:     Peter Robinson <pbrobinson@...il.com>
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
        gbcm-kernel-feedback-list@...adcom.com,
        gkrzysztof.kozlowski+dt@...aro.org, gnsaenz@...nel.org,
        grobh+dt@...nel.org, nsaenz@...nel.org, stefan.wahren@...e.com
Subject: Re: [PATCH] ARM: dts: bcm2711-rpi-4-b: Use aliases to set custom MMC
 device index

Hi Peter,

On 6/12/22 17:38, Peter Robinson wrote:
> On Wed, Jun 8, 2022 at 1:35 PM Ariel D'Alessandro
> <ariel.dalessandro@...labora.com> wrote:
>>
>> Add MMC aliases to ensure that the /dev/mmcblk ID for SD card won't
>> change depending on the probe order of the MMC drivers.
> 
> Is  the bcm2711-rpi.dtsi a better place for it given there's other
> aliases there and it will be consistent across variations?

Yes, indeed, it makes sense moving it to bcm2711-rpi.dtsi

The other board what will be affected by this alias is the Raspberry Pi
Compute Module 4 IO Board, on which emmc2 is the eMMC. However, the
alias makes sense, to have that as the first mmc device.

Maybe we can add the alias as follows?

    mmc0 = &emmc2;  /* mmcblk0 for eMMC/SD */

Regards,
Ariel

> 
>> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@...labora.com>
>> ---
>>  arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
>> index 4432412044de..780812542bad 100644
>> --- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
>> +++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
>> @@ -14,6 +14,10 @@ chosen {
>>                 stdout-path = "serial1:115200n8";
>>         };
>>
>> +       aliases {
>> +               mmc0 = &emmc2;  /* mmcblk0 for SD */
>> +       };
>> +
>>         leds {
>>                 led-act {
>>                         gpios = <&gpio 42 GPIO_ACTIVE_HIGH>;
>> --
>> 2.34.1
>>
>>
>> _______________________________________________
>> linux-rpi-kernel mailing list
>> linux-rpi-kernel@...ts.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives