linux-kernel - Re: [PATCH -next] drm/syncobj: add missing error return code in drm_syncobj_transfer_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4845ad23-476c-97b9-9b3f-d8aaa9027d26@amd.com>
Date:   Mon, 13 Jun 2022 08:51:21 +0200
From:   Christian König <christian.koenig@....com>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Cc:     daniel.vetter@...ll.ch
Subject: Re: [PATCH -next] drm/syncobj: add missing error return code in
 drm_syncobj_transfer_to_timeline()

Am 13.06.22 um 08:34 schrieb Yang Yingliang:
> If dma_fence_unwrap_merge() fails, it should return error code
> in drm_syncobj_transfer_to_timeline()
>
> Fixes: ec8d985ff26f ("drm: use dma_fence_unwrap_merge() in drm_syncobj")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>

Reviewed-by: Christian König <christian.koenig@....com>

Going to push that in a minute.

Thanks,
Christian.

> ---
>   drivers/gpu/drm/drm_syncobj.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> index bbad9e4696e7..0c2be8360525 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -874,8 +874,10 @@ static int drm_syncobj_transfer_to_timeline(struct drm_file *file_private,
>   
>   	fence = dma_fence_unwrap_merge(tmp);
>   	dma_fence_put(tmp);
> -	if (!fence)
> +	if (!fence) {
> +		ret = -ENOMEM;
>   		goto err_put_timeline;
> +	}
>   
>   	chain = dma_fence_chain_alloc();
>   	if (!chain) {