lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Jun 2022 10:13:16 +0300 From: Adrian Hunter <adrian.hunter@...el.com> To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, Michal Simek <michal.simek@...inx.com>, Ulf Hansson <ulf.hansson@...aro.org> Cc: kernel@...gutronix.de, linux-arm-kernel@...ts.infradead.org, linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 4/5] mmc: sdhci-of-arasan: Obviously always return success in remove callback On 11/06/22 00:12, Uwe Kleine-König wrote: > sdhci_pltfm_unregister() returns 0 unconditionally and returning an > error in a platform remove callback isn't very sensible. (The only > effect of the latter is that the device core emits a generic warning and > then removes the device anyhow.) > > So return 0 unconditionally to make it obvious there is no error > forwarded to the upper layers. > > This is a preparation for making platform remove callbacks return void. This preparation seems a bit unnatural. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Acked-by: Adrian Hunter <adrian.hunter@...el.com> > --- > drivers/mmc/host/sdhci-of-arasan.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c > index 757801dfc308..3997cad1f793 100644 > --- a/drivers/mmc/host/sdhci-of-arasan.c > +++ b/drivers/mmc/host/sdhci-of-arasan.c > @@ -1733,7 +1733,6 @@ static int sdhci_arasan_probe(struct platform_device *pdev) > > static int sdhci_arasan_remove(struct platform_device *pdev) > { > - int ret; > struct sdhci_host *host = platform_get_drvdata(pdev); > struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > struct sdhci_arasan_data *sdhci_arasan = sdhci_pltfm_priv(pltfm_host); > @@ -1747,11 +1746,11 @@ static int sdhci_arasan_remove(struct platform_device *pdev) > > sdhci_arasan_unregister_sdclk(&pdev->dev); > > - ret = sdhci_pltfm_unregister(pdev); > + sdhci_pltfm_unregister(pdev); > > clk_disable_unprepare(clk_ahb); > > - return ret; > + return 0; > } > > static struct platform_driver sdhci_arasan_driver = {
Powered by blists - more mailing lists