| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202206132107.XjOgwxUg-lkp@intel.com>
Date: Mon, 13 Jun 2022 21:48:06 +0800
From: kernel test robot <lkp@...el.com>
To: Hector Martin <marcan@...can.st>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [asahilinux:bits/110-smc 11/16]
drivers/power/reset/macsmc-reboot.c:142:37: warning: 'struct power_off_data'
declared inside parameter list will not be visible outside of this
definition or declaration
Hi Hector,
FYI, the error/warning still remains.
tree: https://github.com/AsahiLinux/linux bits/110-smc
head: 7670de8a6b7863d1cb913b78d1a104d18be1b3d1
commit: 233aeafea99e125604d8d5afa06a37c38cd0b93e [11/16] power: reset: macsmc-reboot: Add driver for rebooting via Apple SMC
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220613/202206132107.XjOgwxUg-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/AsahiLinux/linux/commit/233aeafea99e125604d8d5afa06a37c38cd0b93e
git remote add asahilinux https://github.com/AsahiLinux/linux
git fetch --no-tags asahilinux bits/110-smc
git checkout 233aeafea99e125604d8d5afa06a37c38cd0b93e
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/platform/apple/ drivers/power/reset/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
drivers/power/reset/macsmc-reboot.c:54:32: error: field 'sys_off' has incomplete type
54 | struct sys_off_handler sys_off;
| ^~~~~~~
>> drivers/power/reset/macsmc-reboot.c:142:37: warning: 'struct power_off_data' declared inside parameter list will not be visible outside of this definition or declaration
142 | static void macsmc_power_off(struct power_off_data *data)
| ^~~~~~~~~~~~~~
drivers/power/reset/macsmc-reboot.c: In function 'macsmc_power_off':
drivers/power/reset/macsmc-reboot.c:144:44: error: invalid use of undefined type 'struct power_off_data'
144 | struct macsmc_reboot *reboot = data->cb_data;
| ^~
drivers/power/reset/macsmc-reboot.c: At top level:
>> drivers/power/reset/macsmc-reboot.c:156:35: warning: 'struct restart_data' declared inside parameter list will not be visible outside of this definition or declaration
156 | static void macsmc_restart(struct restart_data *data)
| ^~~~~~~~~~~~
drivers/power/reset/macsmc-reboot.c: In function 'macsmc_restart':
drivers/power/reset/macsmc-reboot.c:158:44: error: invalid use of undefined type 'struct restart_data'
158 | struct macsmc_reboot *reboot = data->cb_data;
| ^~
drivers/power/reset/macsmc-reboot.c: At top level:
>> drivers/power/reset/macsmc-reboot.c:170:42: warning: 'struct reboot_prep_data' declared inside parameter list will not be visible outside of this definition or declaration
170 | static void macsmc_reboot_prepare(struct reboot_prep_data *data)
| ^~~~~~~~~~~~~~~~
drivers/power/reset/macsmc-reboot.c: In function 'macsmc_reboot_prepare':
drivers/power/reset/macsmc-reboot.c:172:44: error: invalid use of undefined type 'struct reboot_prep_data'
172 | struct macsmc_reboot *reboot = data->cb_data;
| ^~
drivers/power/reset/macsmc-reboot.c:176:21: error: invalid use of undefined type 'struct reboot_prep_data'
176 | switch (data->mode) {
| ^~
drivers/power/reset/macsmc-reboot.c: In function 'macsmc_reboot_probe':
drivers/power/reset/macsmc-reboot.c:289:44: error: 'RESTART_PRIO_HIGH' undeclared (first use in this function)
289 | reboot->sys_off.restart_priority = RESTART_PRIO_HIGH;
| ^~~~~~~~~~~~~~~~~
drivers/power/reset/macsmc-reboot.c:289:44: note: each undeclared identifier is reported only once for each function it appears in
drivers/power/reset/macsmc-reboot.c:292:15: error: implicit declaration of function 'devm_register_sys_off_handler' [-Werror=implicit-function-declaration]
292 | ret = devm_register_sys_off_handler(&pdev->dev, &reboot->sys_off);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +142 drivers/power/reset/macsmc-reboot.c
104
105 static ssize_t macsmc_ac_power_mode_show(struct device *dev,
106 struct device_attribute *attr, char *buf)
107 {
108 struct macsmc_reboot *reboot = dev_get_drvdata(dev);
109 int len = 0;
110 int i;
111 int mode = nvmem_cell_get_u8(reboot->nvm.pm_setting);
112
113 if (mode < 0)
114 return mode;
115
116 for (i = 0; i < ARRAY_SIZE(ac_power_mode_map); i++)
117 if (mode == ac_power_mode_map[i])
118 len += scnprintf(buf+len, PAGE_SIZE-len,
119 "[%s] ", ac_power_modes[i]);
120 else
121 len += scnprintf(buf+len, PAGE_SIZE-len,
122 "%s ", ac_power_modes[i]);
123 buf[len-1] = '\n';
124 return len;
125 }
126 static DEVICE_ATTR(ac_power_mode, 0644, macsmc_ac_power_mode_show,
127 macsmc_ac_power_mode_store);
128
129 /*
130 * SMC 'MBSE' key actions:
131 *
132 * 'offw' - shutdown warning
133 * 'slpw' - sleep warning
134 * 'rest' - restart warning
135 * 'off1' - shutdown (needs PMU bit set to stay on)
136 * 'susp' - suspend
137 * 'phra' - restart ("PE Halt Restart Action"?)
138 * 'panb' - panic beginning
139 * 'pane' - panic end
140 */
141
> 142 static void macsmc_power_off(struct power_off_data *data)
143 {
144 struct macsmc_reboot *reboot = data->cb_data;
145
146 dev_info(reboot->dev, "Issuing power off (off1)\n");
147
148 if (apple_smc_write_u32_atomic(reboot->smc, SMC_KEY(MBSE), SMC_KEY(off1)) < 0) {
149 dev_err(reboot->dev, "Failed to issue MBSE = off1 (power_off)\n");
150 } else {
151 mdelay(100);
152 WARN_ON(1);
153 }
154 }
155
> 156 static void macsmc_restart(struct restart_data *data)
157 {
158 struct macsmc_reboot *reboot = data->cb_data;
159
160 dev_info(reboot->dev, "Issuing restart (phra)\n");
161
162 if (apple_smc_write_u32_atomic(reboot->smc, SMC_KEY(MBSE), SMC_KEY(phra)) < 0) {
163 dev_err(reboot->dev, "Failed to issue MBSE = phra (restart)\n");
164 } else {
165 mdelay(100);
166 WARN_ON(1);
167 }
168 }
169
> 170 static void macsmc_reboot_prepare(struct reboot_prep_data *data)
171 {
172 struct macsmc_reboot *reboot = data->cb_data;
173 u32 val;
174 u8 shutdown_flag;
175
176 switch (data->mode) {
177 case SYS_RESTART:
178 val = SMC_KEY(rest);
179 shutdown_flag = 0;
180 break;
181 case SYS_POWER_OFF:
182 val = SMC_KEY(offw);
183 shutdown_flag = 1;
184 break;
185 default:
186 return;
187 }
188
189 dev_info(reboot->dev, "Preparing for reboot (%p4ch)\n", &val);
190
191 /* On the Mac Mini, this will turn off the LED for power off */
192 if (apple_smc_write_u32(reboot->smc, SMC_KEY(MBSE), val) < 0)
193 dev_err(reboot->dev, "Failed to issue MBSE = %p4ch (reboot_prepare)\n", &val);
194
195 /* Set the boot_stage to 0, which means we're doing a clean shutdown/reboot. */
196 if (reboot->nvm.boot_stage &&
197 nvmem_cell_set_u8(reboot->nvm.boot_stage, BOOT_STAGE_SHUTDOWN) < 0)
198 dev_err(reboot->dev, "Failed to write boot_stage\n");
199
200 /*
201 * Set the PMU flag to actually reboot into the off state.
202 * Without this, the device will just reboot. We make it optional in case it is no longer
203 * necessary on newer hardware.
204 */
205 if (reboot->nvm.shutdown_flag &&
206 nvmem_cell_set_u8(reboot->nvm.shutdown_flag, shutdown_flag) < 0)
207 dev_err(reboot->dev, "Failed to write shutdown_flag\n");
208
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists