linux-kernel - Re: [PATCH -next] scsi: target: iscsi: Fix NULL pointer dereference in iscsi_conn_auth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <390b38f7-462a-bfad-5e46-21b4e72f8a39@oracle.com>
Date:   Mon, 13 Jun 2022 10:11:17 -0500
From:   michael.christie@...cle.com
To:     Yang Li <yang.lee@...ux.alibaba.com>, martin.petersen@...cle.com,
        Dmitry Bogdanov <d.bogdanov@...ro.com>
Cc:     linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] scsi: target: iscsi: Fix NULL pointer dereference
 in iscsi_conn_auth_required()

On 6/12/22 8:43 PM, Yang Li wrote:
> Fix following coccicheck error:
> ./drivers/target/iscsi/iscsi_target_nego.c:831:13-26: ERROR: se_nacl is
> NULL but dereferenced.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

This was just added in Martin's 5.20 tree in:

a75fcb0912a549c6c1da8395f33271ce06e84acd

scsi: target: iscsi: Extract auth functions

Do we need a Fixes or should the original patch be fixed?

Patch looks ok to me, so if we just add it:

Reviewed-by: Mike Christie <michael.christie@...cle.com>

> ---
>  drivers/target/iscsi/iscsi_target_nego.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c
> index 9ce35a59962b..fb93a1173954 100644
> --- a/drivers/target/iscsi/iscsi_target_nego.c
> +++ b/drivers/target/iscsi/iscsi_target_nego.c
> @@ -827,8 +827,7 @@ static bool iscsi_conn_auth_required(struct iscsit_conn *conn)
>  	 */
>  	se_nacl = conn->sess->se_sess->se_node_acl;
>  	if (!se_nacl) {
> -		pr_debug("Unknown ACL %s is trying to connect\n",
> -			 se_nacl->initiatorname);
> +		pr_debug("Unknown ACL is trying to connect\n");
>  		return true;
>  	}
>