linux-kernel - Re: [RFC 1/3] dt-bindings: arm: Add document for SCMI Virtio backend device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220613173348.t4ibrtzzs5pe6nii@bogus>
Date:   Mon, 13 Jun 2022 18:33:48 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Neeraj Upadhyay <quic_neeraju@...cinc.com>
Cc:     mst@...hat.com, jasowang@...hat.com, cristian.marussi@....com,
        Sudeep Holla <sudeep.holla@....com>, quic_sramana@...cinc.com,
        vincent.guittot@...aro.org, linux-arm-kernel@...ts.infradead.org,
        kvm@...r.kernel.org, virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC 1/3] dt-bindings: arm: Add document for SCMI Virtio backend
 device

On Thu, Jun 09, 2022 at 12:49:54PM +0530, Neeraj Upadhyay wrote:
> Document the properties for ARM SCMI Virtio backend device
> node.
> 
> Signed-off-by: Neeraj Upadhyay <quic_neeraju@...cinc.com>
> ---
>  .../firmware/arm,scmi-vio-backend.yaml        | 85 +++++++++++++++++++
>  1 file changed, 85 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/firmware/arm,scmi-vio-backend.yaml
> 
> diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi-vio-backend.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi-vio-backend.yaml
> new file mode 100644
> index 000000000000..c95d4e093a3c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi-vio-backend.yaml
> @@ -0,0 +1,85 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/firmware/arm,scmi-vio-backend.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: System Control and Management Interface (SCMI) Virtio backend bindings
> +
> +maintainers:
> +  - Neeraj Upadhyay <quic_neeraju@...cinc.com>
> +
> +description: |
> +  This binding defines the interface for configuring the ARM SCMI Virtio
> +  backend using device tree.
> +
> +properties:
> +  $nodename:
> +    const: scmi-vio-backend
> +
> +  compatible:
> +    const: arm,scmi-vio-backend
> +

One only change between this and the existing DT binding is the compatible.
I don't see any explanation here as why this deserves to be separate binding
document. What can't you just add the compatible to the existing one if there
is no other change. If not, please provide details and examples on how it
differs.

-- 
Regards,
Sudeep