linux-kernel - Re: [PATCH 1/2] serial: 8250: Use UART_LCR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a631963-8b76-b14a-892c-9e22a23a55f7@kernel.org>
Date:   Mon, 13 Jun 2022 10:28:27 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] serial: 8250: Use UART_LCR_WLEN8 instead of literal

On 13. 06. 22, 9:57, Ilpo Järvinen wrote:
> Use UART_LCR_WLEN8 instead of literal 0x03 in size_fifo().
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

> ---
>   drivers/tty/serial/8250/8250_port.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
> index 953b0fadfd4c..8365c7ad3576 100644
> --- a/drivers/tty/serial/8250/8250_port.c
> +++ b/drivers/tty/serial/8250/8250_port.c
> @@ -843,7 +843,7 @@ static int size_fifo(struct uart_8250_port *up)
>   	serial_out(up, UART_LCR, UART_LCR_CONF_MODE_A);
>   	old_dl = serial_dl_read(up);
>   	serial_dl_write(up, 0x0001);
> -	serial_out(up, UART_LCR, 0x03);
> +	serial_out(up, UART_LCR, UART_LCR_WLEN8);
>   	for (count = 0; count < 256; count++)
>   		serial_out(up, UART_TX, count);
>   	mdelay(20);/* FIXME - schedule_timeout */


-- 
js
suse labs