linux-kernel - Re: [PATCH 03/20] block, blksnap: module management interface functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <629624d9-4a1c-211b-c37b-4873665f8aea@nvidia.com>
Date:   Mon, 13 Jun 2022 22:44:10 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Sergei Shtepa <sergei.shtepa@...am.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 03/20] block, blksnap: module management interface
 functions


> +static int ioctl_snapshot_wait_event(unsigned long arg)
> +{
> +	int ret = 0;
> +	struct blk_snap_snapshot_event *karg;
> +	struct event *event;
> +
> +	//pr_debug("Wait event\n");

please avoid avove comment style and remove debug statements.

> +	karg = kzalloc(sizeof(struct blk_snap_snapshot_event), GFP_KERNEL);
> +	if (!karg)
> +		return -ENOMEM;

-ck