linux-kernel - Re: [PATCH RFC v2 06/18] libata-scsi: Add ata_scsi_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa907f45-258b-d63f-85a6-10ea8cf44bb8@huawei.com>
Date:   Mon, 13 Jun 2022 10:41:27 +0100
From:   John Garry <john.garry@...wei.com>
To:     Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        <axboe@...nel.dk>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>, <brking@...ibm.com>, <hare@...e.de>,
        <hch@....de>
CC:     <linux-block@...r.kernel.org>, <linux-ide@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        <chenxiang66@...ilicon.com>
Subject: Re: [PATCH RFC v2 06/18] libata-scsi: Add ata_scsi_queue_internal()

On 13/06/2022 08:12, Damien Le Moal wrote:
>> -	if (dev->class == ATA_DEV_ATA || dev->class == ATA_DEV_ZAC) {
>> +	if (scsi_is_reserved_cmd(scmd)) {
>> +		return ata_scsi_queue_internal(scmd, dev);
>> +	} else if (dev->class == ATA_DEV_ATA || dev->class == ATA_DEV_ZAC) {
> No need for the else here.
> 

Ah, yes

Thanks,
John