linux-kernel - RE: [PATCH 0/8] interconnect: support i.MX8MP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Jun 2022 01:23:18 +0000
From:   Peng Fan <peng.fan@....com>
To:     "Peng Fan (OSS)" <peng.fan@....nxp.com>,
        "djakov@...nel.org" <djakov@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>, Abel Vesa <abel.vesa@....com>,
        "abailon@...libre.com" <abailon@...libre.com>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "laurent.pinchart@...asonboard.com" 
        <laurent.pinchart@...asonboard.com>,
        "marex@...x.de" <marex@...x.de>,
        "paul.elder@...asonboard.com" <paul.elder@...asonboard.com>,
        "Markus.Niebel@...tq-group.com" <Markus.Niebel@...tq-group.com>,
        "aford173@...il.com" <aford173@...il.com>
CC:     "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH 0/8] interconnect: support i.MX8MP

All,

> Subject: [PATCH 0/8] interconnect: support i.MX8MP

I am going to send out V2 this week to address the comments until now.
But before that I would like to see if any one has any comments on the
design here.

Georgi, do you have comments on Patch 2 " interconnect: add device
managed bulk API"

Lucas, since you had comments when I first use syscon to configure NoC,
are you ok with the design to use interconnect in this patchset?

Thanks,
Peng.

> 
> From: Peng Fan <peng.fan@....com>
> 
> This patchset is to support i.MX8MP NoC settings, i.MX8MP NoC initial value
> after power up is invalid, need set a valid value after related power domain up.
> 
> This patchset also includes two patch[1,2] during my development to enable the
> ICC feature for i.MX8MP.
> 
> I not include ddrc DVFS in this patchset, ths patchset is only to support NoC
> value mode/priority/ext_control being set to a valid value that suggested by
> i.MX Chip Design Team. The value is same as NXP downstream one inside Arm
> Trusted Firmware:
> https://source.codeaurora.org/external/imx/imx-atf/tree/plat/imx/imx8m/imx
> 8mp/gpc.c?h=lf_v2.4#n97
> 
> A repo created here:
> https://github.com/MrVan/linux/tree/imx8mp-interconnect
> 
> Peng Fan (8):
>   dt-bindings: interconnect: imx8m: Add bindings for imx8mp noc
>   interconnect: add device managed bulk API
>   interconnect: imx: fix max_node_id
>   interconnect: imx: set src node
>   interconnect: imx: introduce imx_icc_provider
>   interconnect: imx: set of_node for interconnect provider
>   interconnect: imx: configure NoC mode/prioriry/ext_control
>   interconnect: imx: Add platform driver for imx8mp
> 
>  .../bindings/interconnect/fsl,imx8m-noc.yaml  |   6 +
>  drivers/interconnect/bulk.c                   |  34 +++
>  drivers/interconnect/imx/Kconfig              |   4 +
>  drivers/interconnect/imx/Makefile             |   2 +
>  drivers/interconnect/imx/imx.c                |  68 +++--
>  drivers/interconnect/imx/imx.h                |  25 +-
>  drivers/interconnect/imx/imx8mm.c             |   2 +-
>  drivers/interconnect/imx/imx8mn.c             |   2 +-
>  drivers/interconnect/imx/imx8mp.c             | 232
> ++++++++++++++++++
>  drivers/interconnect/imx/imx8mq.c             |   2 +-
>  include/dt-bindings/interconnect/fsl,imx8mp.h |  59 +++++
>  include/linux/interconnect.h                  |   6 +
>  12 files changed, 424 insertions(+), 18 deletions(-)  create mode 100644
> drivers/interconnect/imx/imx8mp.c  create mode 100644
> include/dt-bindings/interconnect/fsl,imx8mp.h
> 
> --
> 2.25.1