linux-kernel - Re: [PATCH] x86: kvm: remove NULL check before kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zgifihcd.fsf@redhat.com>
Date:   Tue, 14 Jun 2022 14:01:54 +0200
From:   Vitaly Kuznetsov <vkuznets@...hat.com>
To:     Dongliang Mu <dzm91@...t.edu.cn>
Cc:     mudongliang <mudongliangabcd@...il.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: kvm: remove NULL check before kfree

Dongliang Mu <dzm91@...t.edu.cn> writes:

> From: mudongliang <mudongliangabcd@...il.com>
>
> kfree can handle NULL pointer as its argument.
> According to coccinelle isnullfree check, remove NULL check
> before kfree operation.
>
> Signed-off-by: mudongliang <mudongliangabcd@...il.com>
> ---
>  arch/x86/kernel/kvm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
> index 1a3658f7e6d9..d4e48b4a438b 100644
> --- a/arch/x86/kernel/kvm.c
> +++ b/arch/x86/kernel/kvm.c
> @@ -236,8 +236,7 @@ void kvm_async_pf_task_wake(u32 token)
>  	raw_spin_unlock(&b->lock);
>  
>  	/* A dummy token might be allocated and ultimately not used.  */
> -	if (dummy)
> -		kfree(dummy);
> +	kfree(dummy);
>  }
>  EXPORT_SYMBOL_GPL(kvm_async_pf_task_wake);

Reviewed-by: Vitaly Kuznetsov <vkuznets@...hat.com>

-- 
Vitaly