[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YqiCEHTauCoceNNI@kroah.com>
Date: Tue, 14 Jun 2022 14:41:52 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Kai Ye <yekai13@...wei.com>
Cc: herbert@...dor.apana.org.au, linux-crypto@...r.kernel.org,
linux-accelerators@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
linuxarm@...wei.com, zhangfei.gao@...aro.org,
wangzhou1@...ilicon.com
Subject: Re: [PATCH v2 2/3] Documentation: add a isolation strategy vfs node
for uacce
On Tue, Jun 14, 2022 at 08:29:39PM +0800, Kai Ye wrote:
> Update documentation describing DebugFS that could help to
> configure hard error frequency for users in th user space.
>
> Signed-off-by: Kai Ye <yekai13@...wei.com>
> ---
> Documentation/ABI/testing/sysfs-driver-uacce | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-driver-uacce b/Documentation/ABI/testing/sysfs-driver-uacce
> index 08f2591138af..0c4226364182 100644
> --- a/Documentation/ABI/testing/sysfs-driver-uacce
> +++ b/Documentation/ABI/testing/sysfs-driver-uacce
> @@ -19,6 +19,23 @@ Contact: linux-accelerators@...ts.ozlabs.org
> Description: Available instances left of the device
> Return -ENODEV if uacce_ops get_available_instances is not provided
>
> +What: /sys/class/uacce/<dev_name>/isolate_strategy
> +Date: Jun 2022
> +KernelVersion: 5.19
> +Contact: linux-accelerators@...ts.ozlabs.org
> +Description: A vfs node that used to configures the hardware
What is a "vfs node"?
> + error frequency. This frequency is abstract. Like once an hour
> + or once a day. The specific isolation strategy can be defined in
> + each driver module.
No, you need to be specific here and describe the units and the format.
Otherwise it is no description at all :(
> +
> +What: /sys/class/uacce/<dev_name>/isolate
> +Date: Jun 2022
> +KernelVersion: 5.19
5.19 will not have this change.
> +Contact: linux-accelerators@...ts.ozlabs.org
> +Description: A vfs node that show the device isolated state. The value 0
> + means that the device is working. The value 1 means that the
> + device has been isolated.
What does "working" or "isolated" mean?
thanks,
greg k-h
Powered by blists - more mailing lists