[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <15dac932-ab2d-1c2e-6438-75e8eda6dd62@redhat.com>
Date: Tue, 14 Jun 2022 15:03:42 +0200
From: Javier Martinez Canillas <javierm@...hat.com>
To: José Expósito <jose.exposito89@...il.com>
Cc: davidgow@...gle.com, dlatypov@...gle.com, tzimmermann@...e.de,
maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
airlied@...ux.ie, daniel@...ll.ch, jani.nikula@...ux.intel.com,
dri-devel@...ts.freedesktop.org, kunit-dev@...glegroups.com,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/3] KUnit tests for drm_format_helper
On 6/13/22 19:17, José Expósito wrote:
> Hello everyone,
>
> Here is the v3 of the series, including the documentation, previously
> sent as a standalone patch [1], and changes suggested during review.
>
> Thanks a lot,
> José Expósito
>
Before merging this, could you please reach the folks working on [0] ?
I think that would be good to have some consistency with regard to KUnit
tests from the start to avoid future refactorings. For instance, you are
adding the tests under a `kunit` sub-directory while they are doing it
in a `tests` sub-dir.
Also there may be other things that could be made more consistent, like
the naming conventions for the tests, suites, etc.
[0]: https://lore.kernel.org/all/20220608010709.272962-4-maira.canal@usp.br/T/
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
Powered by blists - more mailing lists