linux-kernel - Re: [PATCH] driver: hwmon: remove NULL check before kvfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e44c0dfa-927d-7c08-66f0-6c79be1595b1@roeck-us.net>
Date:   Tue, 14 Jun 2022 06:19:14 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Dongliang Mu <dzm91@...t.edu.cn>, Jean Delvare <jdelvare@...e.com>,
        Eddie James <eajames@...ux.ibm.com>,
        Joel Stanley <joel@....id.au>,
        mudongliang <mudongliangabcd@...il.com>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>
Cc:     linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver: hwmon: remove NULL check before kvfree

On 6/14/22 01:56, Dongliang Mu wrote:
> From: mudongliang <mudongliangabcd@...il.com>
> 
> kvfree can handle NULL pointer as its argument.
> According to coccinelle isnullfree check, remove NULL check
> before kvfree operation.
> 

Please add driver information to your subject lines, and drop
"driver:". It should be

  [PATCH] hwmon: (occ) remove NULL check before kvfree

> Signed-off-by: mudongliang <mudongliangabcd@...il.com>

Please provide your full name here. This should be

Signed-off-by: Dongliang Mu <mudongliangabcd@...il.com>

Thanks,
Guenter

> ---
>   drivers/hwmon/occ/p9_sbe.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/hwmon/occ/p9_sbe.c b/drivers/hwmon/occ/p9_sbe.c
> index 42fc7b97bb34..01405ae2f9bd 100644
> --- a/drivers/hwmon/occ/p9_sbe.c
> +++ b/drivers/hwmon/occ/p9_sbe.c
> @@ -55,8 +55,7 @@ static bool p9_sbe_occ_save_ffdc(struct p9_sbe_occ *ctx, const void *resp,
>   	mutex_lock(&ctx->sbe_error_lock);
>   	if (!ctx->sbe_error) {
>   		if (resp_len > ctx->ffdc_size) {
> -			if (ctx->ffdc)
> -				kvfree(ctx->ffdc);
> +			kvfree(ctx->ffdc);
>   			ctx->ffdc = kvmalloc(resp_len, GFP_KERNEL);
>   			if (!ctx->ffdc) {
>   				ctx->ffdc_len = 0;
> @@ -171,8 +170,7 @@ static int p9_sbe_occ_remove(struct platform_device *pdev)
>   	ctx->sbe = NULL;
>   	occ_shutdown(occ);
>   
> -	if (ctx->ffdc)
> -		kvfree(ctx->ffdc);
> +	kvfree(ctx->ffdc);
>   
>   	return 0;
>   }