[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdW3uxQHk6SBX5MqnZsYqwY8p+0wmD6gHwS3ESUrkmpWkQ@mail.gmail.com>
Date: Tue, 14 Jun 2022 15:54:03 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
Niklas Söderlund <niklas.soderlund@...natech.se>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Amit Kucheria <amitk@...nel.org>,
Zhang Rui <rui.zhang@...el.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Linux PM list <linux-pm@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add
r8a779f0 support
Hi Wolfram,
On Fri, Jun 10, 2022 at 10:17 PM Wolfram Sang
<wsa+renesas@...g-engineering.com> wrote:
> Add support for R-Car S4. The S4 IP differs a bit from its siblings in
> such way that it has 3 out of 4 TSC nodes for Linux and the interrupts
> are not routed to the INTC-AP but to the ECM.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
>
> Change since V2:
> * make interrupts not required for this SoC
Thanks for the update!
Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> @@ -79,8 +80,16 @@ else:
> - description: TSC1 registers
> - description: TSC2 registers
> - description: TSC3 registers
> - required:
> - - interrupts
> + if:
> + not:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,r8a779f0-thermal
> + then:
> + required:
> + - interrupts
While correct, IMHO adding this check here loses again the improvement
made by "[PATCH v3 1/2] dt-bindings: thermal: rcar-gen3-thermal: use
positive logic".
What about splitting this in two separate checks at the top level:
- one for regs (R-Car V3U vs. the world), and
- a second for interrupts (R-Car V3U+S4-8 vs. the world)?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists